Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning if outcomes are not {-1,1} #118

Open
lukelikelihood opened this issue Jul 14, 2020 · 0 comments
Open

Raise warning if outcomes are not {-1,1} #118

lukelikelihood opened this issue Jul 14, 2020 · 0 comments

Comments

@lukelikelihood
Copy link

Hey,

I noticed this issue while assisting a colleague who used hBayesDM to fit a number of models for binary decision data (2-armed bandit, fictitious learning, RPL...). By accident, he used outcome data that was coded as "0" for no reward/punishment, "1" for reward. Looking through the stan files, it looks to me as if the models will only work as intended if outcomes are coded using "-1" and "1", but using "0" and "1" does also not lead to an error or warning.

It would be good if outcomes were, by default, checked to be of the required type, and if a warning (or even an error) were raised if that is not the case.

Best,
Lukas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant