Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDC Portal Site in React, TailwindCSS, NextJS #14

Open
wants to merge 82 commits into
base: master
Choose a base branch
from

Conversation

jordontgarcia
Copy link

@jordontgarcia jordontgarcia commented Jun 4, 2022

Remake of the CDC Portal Site in React/NextJS + TailwindCSS, utilizing progressive SSR and dynamic routes on Vercel. Encouraging others to consider joining development, to further innovate and progress the site for user functionality features!
Check out the live preview on this link: https://cdc-portal.vercel.app/

@leebrian
Copy link
Member

leebrian commented Jun 8, 2022

Thanks so much for working on this and submitting the PR. I tried accessing on https://cdc-portal.vercel.app/ and it looks like there is not feature parity with the existing code portal. Here are the differences I see:

  • Project images aren't showing
  • yours shows 210, https://cdcgov.github.io/ shows 212
  • not able to search by programming language
  • missing different sort options
  • look and feel differences where I don't understand the intended benefit of the change
  • "Launch" buttons are missing from projects that have web sites (like opencdc)
  • missing watcher and star counts from cards
  • shows a date on each card, not sure what this is, create date maybe?

I like that you're innovative in using these new UI frameworks, but I don't think I can accept this PR as it would remove functionality that users currently have. If you can bring this up to feature parity, then I'm happy to merge it in and update the site.

@jordontgarcia
Copy link
Author

Appreciate the insight and the review! The feature parity difference was going to be my next plan on the project! I'm happy to bring all the features you offer from the current production build, to this one! Will definitely spend some time and apply effort to the highlights you provided. Thank you again for the open collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants