Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example csv to include testkit name id and equipment model id #619

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

DanielSass
Copy link
Collaborator

Related Issue or Background Info

Updating the example csv to account for new fields added to the guide.

CDCgov/prime-simplereport#6881
CDCgov/prime-simplereport#4896

Changes Proposed

Add test_kit_name_id and equipment_model_id columns.

Additional Information

Screenshots / Demos

Checklist for Author and Reviewer

Design

  • Any UI/UX changes have a designer as a reviewer, and changes have been approved
  • Any large-scale changes have been deployed to test, dev, or pentest and smoke-tested by both the engineering and design teams

Content

  • Any content changes (including new error messages) have been approved by content team

Support

  • Any changes that might generate new support requests have been flagged to the support team

Testing

  • Includes a summary of what a code reviewer should verify

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this!

@mpbrown mpbrown merged commit e8b33d6 into main Dec 19, 2023
6 checks passed
@mpbrown mpbrown deleted the dan/4896-bulk-upload-guide-updates branch December 19, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants