-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint from 8.57.0 to 9.0.0 #681
Conversation
eslint.config.js
Outdated
@@ -0,0 +1,27 @@ | |||
import frontmatter from "eslint-plugin-frontmatter" | |||
|
|||
export default [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't for the life of me get these pattern matching values to work. Setting the files
or ignore
keys result in either all the files under the relevant assets/js
directory to be ignored or none of them to be ignored.
Going to punt and revisit this in a pairing session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after pairing on it for an hour the only thing Elisa and I could figure out is to hard code the one file we're linting 🤷♂️
Will punt this problem to whoever writes more javascript for the static site in the future but we were going crazy trying to get this to work.
A newer version of eslint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.0.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.0.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
35957b8
to
eb9e9b8
Compare
@@ -57,8 +57,7 @@ | |||
"@uswds/compile": "^1.1.0", | |||
"autoprefixer": "^10.4.19", | |||
"del": "^6.0.0", | |||
"eslint": "^8.57.0", | |||
"eslint-plugin-frontmatter": "0.0.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We weren't using this plugin anymore so went ahead and removed it
@@ -6,7 +6,7 @@ | |||
// Form components are namespaced under 'fba' = 'Feedback Analytics' | |||
"use strict"; | |||
|
|||
function FBAform(d, N) { | |||
function FBAform(d) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went ahead and added the touchpoints form into the linting setup / fixed the errors there.
Bumps eslint from 8.57.0 to 9.0.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
e0cbc50
9.0.075cb5f4
Build: changelog update for 9.0.019f9a89
chore: Update dependencies for v9.0.0 (#18275)7c957f2
chore: package.json update for@eslint/js
released73a33c
chore: ignore/docs/v8.x
in link checker (#18274)d54a412
feat: Add --inspect-config CLI flag (#18270)e151050
docs: update get-started to the new@eslint/create-config
(#18217)610c148
fix: Supportusing
declarations in no-lone-blocks (#18269)44a81c6
chore: upgrade knip (#18272)94178ad
docs: mention aboutname
field in flat config (#18252)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)