-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint from 8.57.0 to 9.0.0 #681
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2854bb1
Bump eslint from 8.57.0 to 9.0.0
dependabot[bot] e75c2f1
migrate to 9.0
fzhao99 fa5f660
add config file
fzhao99 d362e5f
try ignore glob matching
fzhao99 54abc68
just hard code the one file we're linting
fzhao99 eb9e9b8
regen yarn lock after merge conflicts
fzhao99 9cb2fb1
eslint ignore patterns be confusing
fzhao99 c753f12
make config module and remove unnecessary plugin
fzhao99 8d83589
add new config file
fzhao99 7be8557
lint touchpoints form too
fzhao99 b5298ec
unexport touchpoints form
fzhao99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import globals from "globals"; | ||
import js from '@eslint/js'; | ||
|
||
export default [ | ||
{ | ||
files:["assets/**/*.js"], | ||
languageOptions: { | ||
ecmaVersion: 2020, | ||
sourceType: "module", | ||
globals: { | ||
...globals.browser, | ||
} | ||
}, | ||
...js.configs.recommended | ||
}, | ||
{ | ||
ignores: [ | ||
"**/uswds*.js", | ||
"**/main.js", | ||
"**/anchor*.js", | ||
], | ||
} | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
"uswds-update": "npm update uswds", | ||
"uncss": "gulp uncss", | ||
"watch": "gulp watch", | ||
"eslint": "eslint assets/js/", | ||
"eslint": "eslint", | ||
"build": "gulp build-sass && bundle exec jekyll build --config _config.yml", | ||
"build:dev": "gulp build-sass && bundle exec jekyll build --config _config.yml,_dev_config.yml", | ||
"build:dev2": "gulp build-sass && bundle exec jekyll build --config _config.yml,_dev2_config.yml", | ||
|
@@ -57,8 +57,7 @@ | |
"@uswds/compile": "^1.1.0", | ||
"autoprefixer": "^10.4.19", | ||
"del": "^6.0.0", | ||
"eslint": "^8.57.0", | ||
"eslint-plugin-frontmatter": "0.0.8", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We weren't using this plugin anymore so went ahead and removed it |
||
"eslint": "^9.0.0", | ||
"gulp": "^4.0.2", | ||
"gulp-postcss": "^9.1.0", | ||
"gulp-rename": "^2.0.0", | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went ahead and added the touchpoints form into the linting setup / fixed the errors there.