Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Matrix API #336

Closed
blegouix opened this issue Mar 8, 2024 · 3 comments
Closed

Simplify Matrix API #336

blegouix opened this issue Mar 8, 2024 · 3 comments
Assignees
@blegouix

Comments

@blegouix
Copy link
Collaborator

blegouix commented Mar 8, 2024

@EmilyBourne proposes to simplify the Matrix API with an intermediate MatrixLapack class and specialized solve_inplace for MatrixSparse and MatrixLapack.

solve_inplace_method would be removed or defined independently in MatrixLapack and MatrixSparse, but won't be a virtual function of Matrix anymore
@blegouix blegouix self-assigned this Apr 2, 2024
@blegouix
Copy link
Collaborator Author

blegouix commented Apr 8, 2024

I wait #329 to be merged

@blegouix
Copy link
Collaborator Author

Duplicate with #425

@EmilyBourne
Copy link
Collaborator

I am not sure that this is a duplicate. Issues are for defining work to be done while discussions are about finding the right approach so an issue can be described. That said there is definitely a large overlap. I think we should probably edit and re-open this issue once a conclusion has been reached about the right interface to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blegouix @EmilyBourne