Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate is_spline_interpolation_mesh_uniform #492

Open
EmilyBourne opened this issue Jun 12, 2024 · 2 comments
Open

Deprecate is_spline_interpolation_mesh_uniform #492

EmilyBourne opened this issue Jun 12, 2024 · 2 comments

Comments

@EmilyBourne
Copy link
Collaborator

The function is_spline_interpolation_mesh_uniform does not make sense. It is described as:

/**
* @brief A helper giving the uniform/non_uniform status of a spline interpolation mesh according to its attributes.
*
* A helper giving the uniform/non_uniform status of a spline interpolation mesh according to its attributes.
*
* @param is_uniform A boolean giving the presumed status before considering boundary conditions.
* @param BcXmin The lower boundary condition.
* @param BcXmax The upper boundary condition.
* @param degree The degree of the spline.
*
* @return A boolean giving the uniform/non_uniform status.
*/

However in reality it gives the uniform/non_uniform status of greville abcissae. The interpolation points have been decoupled from the greville abcissae for a while so this function should not be used. It should therefore be deprecated

@EmilyBourne
Copy link
Collaborator Author

@tpadioleau
Copy link
Member

Ok if it is no longer used then we will bypass the deprecating stage and remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants