Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on deep copies in SplineBuilder #511

Closed
wants to merge 21 commits into from

Conversation

blegouix
Copy link
Collaborator

Closes #508

@blegouix blegouix self-assigned this Jun 27, 2024
@blegouix blegouix marked this pull request as draft June 27, 2024 17:38
@blegouix
Copy link
Collaborator Author

Sad but this branch is actually slower than the main (transpositions)... I wonder how deepcopies between LayoutRight and LayoutStride views on GPU could be slower (by a factor of ~3) than explicitely writing the parallel_for which do the same

@blegouix blegouix changed the base branch from main to spline-builder-optimize July 2, 2024 09:02
@blegouix
Copy link
Collaborator Author

blegouix commented Jul 2, 2024

I archive this in favor of #517

@blegouix blegouix closed this Jul 2, 2024
@blegouix blegouix deleted the deep-copies-in-spline-builder branch July 2, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite SplineBuilder internal parallel_for_each with parallel_deep_copy
1 participant