Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a configuration file containing preprocessor definitions #666

Open
tpadioleau opened this issue Oct 24, 2024 · 3 comments · May be fixed by #672
Open

Create a configuration file containing preprocessor definitions #666

tpadioleau opened this issue Oct 24, 2024 · 3 comments · May be fixed by #672
Assignees
@tpadioleau

Comments

@tpadioleau
Copy link
Member

Following #665, instead of propagating definitions with target_compile_definitions I would prefer that we generate a ddc_config.hpp with these definitions. It would be cleaner for projects relying on DDC.
@tpadioleau tpadioleau mentioned this issue Oct 24, 2024
Open
@tpadioleau
Copy link
Member Author

I would remove some of the preprocessor definitions:

  • DDC_BUILD_KERNELS_FFT
  • DDC_BUILD_KERNELS_SPLINES
  • DDC_BUILD_PDI_WRAPPER

It is not clear anymore why we should expose them to the user.

@jbigot
Copy link
Member

jbigot commented Oct 31, 2024

Agreed, no reason I see for that

@tpadioleau
Copy link
Member Author

Only some of our examples use DDC_BUILD_PDI_WRAPPER but we can work around

@tpadioleau tpadioleau linked a pull request Oct 31, 2024 that will close this issue
Remove unnecessary compile definitions #672
Open
@tpadioleau tpadioleau self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpadioleau tpadioleau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary compile definitions CExA-project/ddc
2 participants
@jbigot @tpadioleau