Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide automated versioned build system #46

Closed
airtonix opened this issue Oct 13, 2023 · 1 comment · Fixed by #47 or #51
Closed

provide automated versioned build system #46

airtonix opened this issue Oct 13, 2023 · 1 comment · Fixed by #47 or #51
Labels
enhancement New feature or request

Comments

@airtonix
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  • follow conventional commit pattern in PR titles
  • merging PRs to main triggers a process that creates or keeps a release PR updated
  • merging the release PR computes a version and makes a release build uploaded to that release tag
  • a generated CHANGELOG is created or updated.

Describe the solution you'd like

release-please

Describe alternatives you've considered

Additional context

I've done similar work for nvim-telescope/telescope-fzf-native.nvim#93 (yet to be merged as they don't seem to be in a hurry)
@airtonix airtonix added the enhancement New feature or request label Oct 13, 2023
@airtonix airtonix mentioned this issue Oct 13, 2023
Merged
4 tasks
@CHollingworth CHollingworth linked a pull request Oct 16, 2023 that will close this issue
Feat: Merge 1.0.9 into master #51
Merged
12 tasks
CHollingworth added a commit that referenced this issue Nov 3, 2023
@airtonix @CHollingworth
feat: Provide automated build system (#47)
f8755c5 
fixes #46 

The way this works: 

- update repo settings: 
  - require passing status checks
  - only allow squash merge PRs


![image](https://github.com/CHollingworth/Lamp/assets/61225/9cf4092f-2812-43f5-ba08-1a09ccfd3f24)



- when a PR is merged:
  - release-please runs and looks for a PR it previously created
- if none is found it makes one with a preview of the new changelog
entries
- if one is found, it updates the PR with a preview of the new changelog
entries
  - when you merge the release-please PR
- it computes the version based on the commit messages between the last
release and this release
    - it then creates a tag for that version
- this workflow then runs a build and uploads that compiled `lamp` as a
downloadable asset on that tagged release


- [x] automate build locally with docker to mimic github action
environment.
- [x] test the github action in my own forked repo.
- [x] provide github workflow that fails PRs until their title conforms
to required pattern.
- [X] provide a PR template to help guide people in creating successful
PRs

---------

Co-authored-by: CHollingworth <->
Co-authored-by: Charles Hollingworth <[email protected]>
@CHollingworth
Copy link
Owner

Ill close this for now, as we are actively pushing the changes to 1.0.9

@airtonix airtonix mentioned this issue Nov 4, 2023
Merged
CHollingworth added a commit that referenced this issue Nov 4, 2023
@airtonix @CHollingworth @github-actions
fix: release automation take 3 (#60)
a027340 
fixes #47 

see #46 for more information

---------

Co-authored-by: CHollingworth <->
Co-authored-by: Charles Hollingworth <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@airtonix airtonix mentioned this issue Nov 4, 2023
Merged
CHollingworth added a commit that referenced this issue Nov 4, 2023
@airtonix @CHollingworth
feat: release automation (#61)
061139a 
fixes #46

---------

Co-authored-by: CHollingworth <->
Co-authored-by: Charles Hollingworth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@airtonix @CHollingworth