Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit to CRAN #5

Open
nmpeterson opened this issue May 26, 2021 · 0 comments
Open

Submit to CRAN #5

nmpeterson opened this issue May 26, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nmpeterson
Copy link
Contributor

Potential issues to iron out first:

  • Package is large (~75MB) because it is basically a data repository. They should allow it, but if not the package could be updated to replaces the Census geoms with functions that fetch and cache those datasets using tigris (i.e. just adapt the code in data-raw/load_census_api.R)
  • Some examples (block_sf, blockgroup_sf, xwalk_blockgroup2cca) are very slow because they either (a) use ggplot to create maps of complex geometries, or (b) summarize large tables. Any slow xwalk_* examples should be migrated into a vignette (as part of Create vignettes #4). Hopefully there is a faster method for mapping blocks & block groups (tmap?), but if nothing is fast enough, \dontrun{} can be a last resort.
@nmpeterson nmpeterson self-assigned this May 26, 2021
@dlcomeaux dlcomeaux added the enhancement New feature or request label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants