Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

core option in actor #253

Closed
vlimant opened this issue Dec 15, 2017 · 4 comments
Closed

core option in actor #253

vlimant opened this issue Dec 15, 2017 · 4 comments

Comments

@vlimant
Copy link
Contributor

vlimant commented Dec 15, 2017

@areinsvo making a GH so that we keep track of this.
looks like the "cores" option is not wired in actor.

can you please remind me why you copied the singleRecovery function from recoveror.py instead of importing it ?
please take a look there and try to import it, the core (NOTE core vs coreS) option is added already so that resubmit.py works
FYI @prozober

@paorozo
Copy link

paorozo commented Dec 15, 2017

@areinsvo
Copy link
Contributor

It was easier to copy singleRecovery, rather than import it, because of differences in the input. I wanted to have control over how things were being implemented.
For example, in actor.py memory is given in the json as 'memory': '20000' to set the memory to 20000, whereas for recoveror.py it would be 'mem-+1000' to increase the memory by 1000. It was non-trivial to a) understand the recoveror format and b) translate the actor format to the recoveror format.

However, then we run into issues such as these, when they become out of sync.

For now I will try to quickly add the multicore functionality to actor.py. Next week I can look into what changes are needed to import singleRecovery instead.

@paorozo
Copy link

paorozo commented Jan 4, 2018

Hi @areinsvo, do you think we are close to using this option from the recovery tool?
@dabercro, I think we need to have something like CMSCompOps/WorkflowWebTools#87 (comment) for this parameter and display the multicore value close to the textbox. It'd help me a lot!

@areinsvo
Copy link
Contributor

areinsvo commented Jan 4, 2018

@prozober I'll probably be ready to test the multicore functionality tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants