Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 3.2.3 does not compiles on windows (__BYTE_ORDER_ not defined) #31

Open
AlexisCompain opened this issue Oct 25, 2023 · 1 comment

Comments

@AlexisCompain
Copy link

AlexisCompain commented Oct 25, 2023

Following the latest update (d346e0f) the compilation does not work on windows (msvc 2019)
I got compilation errors on include/CommonAPI/SomeIP/OutputStream.hpp (_BYTE_ORDER not defined)
d346e0f#diff-4c81b6e7390e799245076afd2b9125066fb6b2c4f727949f4bc5cc46f633c0bfR570-R595

For some reason, code has been factorised and is now not compiling.
gcc seems to allow usage of compiler definition in normal if/else condition, but msvc does not allow it.

The compilation works fine after reverting lines 570-595 of OutputStream.hpp (same functional behaviour)

@goncaloalmeida
Copy link
Collaborator

hello @AlexisCompain
thanks for the input.
We will check internally and solve this in the next version.

cc @DiogoPedrozza @dibpinto @fcmonteiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants