Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Validate phone number for subscription #44

Open
1 of 3 tasks
acthelemann opened this issue Apr 23, 2020 · 0 comments
Open
1 of 3 tasks

[FEAT] Validate phone number for subscription #44

acthelemann opened this issue Apr 23, 2020 · 0 comments
Labels
backend Anything related to the Golang microservice enhancement New feature or request

Comments

@acthelemann
Copy link
Contributor

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

In the subscribe lambda:

  • Validate the phone number is of E.164 format
  • If the phone number is not valid, respond with a 400 status code

Motivation

Phone numbers being subscribed to the notification service should be of a consistent format and should be able to support international numbers.

Possible Alternatives

Only do this check on the frontend.

Additional Context

E.164 format

@acthelemann acthelemann added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed backend Anything related to the Golang microservice labels Apr 23, 2020
@acthelemann acthelemann removed good first issue Good for newcomers help wanted Extra attention is needed labels Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Anything related to the Golang microservice enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant