Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate mock data json - structure #20

Merged
merged 1 commit into from
May 12, 2020
Merged

Generate mock data json - structure #20

merged 1 commit into from
May 12, 2020

Conversation

pavel-ilin
Copy link

⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.

All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.

Before submitting a pull request, please be sure to review:


Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #15

Summary

Begin working on ruby script which generate mock data.

Details

  • add initial ruby script /mock-data/gen.rb
  • gen.rb generate this json file /mock-data/mockData.json

Before we start adding any logic, I want to make sure that structure of the json file is good enough.

Test Plan (required)

Open /mock-data/mockData.json

or

cd mock-data and ruby gen.rb

Final Checklist

  • For CoronaTracker, did you bump the version in package.json?
    • Update the second decimal for a major change
    • Update the third decimal for a minor change
    • Numbers can go past 9, e.g. 1.0.9 => 1.0.10
    • For more info, read about Semantic Versioning
  • Did you add any new tests as necessary?
  • Is your PR rebased off the most current master?
  • Have you squashed all commits? (can be done at merge)
  • Did you use yarn not npm? (important!)
  • Did you use Material-UI wherever possible?
  • Did you run yarn lint on the code?
  • Did you run all of your most recent changes locally to make sure everything is working?

@pavel-ilin pavel-ilin requested review from ngiangre and salvolpe May 12, 2020 01:05
Copy link
Member

@SomeMoosery SomeMoosery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'm not too well-versed in Ruby :)

@ngiangre ngiangre merged commit 8ce92c3 into COVID-19-electronic-health-system:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ammend Typos and Expand Mock-Data
3 participants