feat: add hugr-core StaticGraph, deprecate hugr-passes CallGraph #2698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2698 +/- ##
==========================================
- Coverage 83.53% 83.49% -0.05%
==========================================
Files 264 265 +1
Lines 51538 51643 +105
Branches 47006 47108 +102
==========================================
+ Hits 43051 43117 +66
- Misses 6114 6154 +40
+ Partials 2373 2372 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mark-koch
approved these changes
Nov 18, 2025
Contributor
mark-koch
left a comment
mark-koch
left a comment
There was a problem hiding this comment.
Looks good to me 👍
In terms of naming, I think I slightly prefer ModuleGraph since it only contains nodes on module level and not all static edges are included (e.g. consts inside functions)
| } | ||
|
|
||
| /// Details the [`FuncDefn`]s, [`FuncDecl`]s and module-level [`Const`]s in a Hugr, | ||
| /// in a Hugr, along with the [`Call`]s, [`LoadFunction`]s, and [`LoadConstant`]s connecting them. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// in a Hugr, along with the [`Call`]s, [`LoadFunction`]s, and [`LoadConstant`]s connecting them. | |
| /// along with the [`Call`]s, [`LoadFunction`]s, and [`LoadConstant`]s connecting them. |
hugr-core/src/static_graph.rs
Outdated
| } | ||
|
|
||
| impl<N: HugrNode> StaticGraph<N> { | ||
| /// Makes a new `CallGraph` for a Hugr. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Makes a new `CallGraph` for a Hugr. | |
| /// Makes a new `StaticGraph` for a Hugr. |
| /// | ||
| /// If the node is not recognised as a function or the entrypoint, | ||
| /// for example if it is a [`Const`](OpType::Const), the iterator will be empty. | ||
| pub fn out_edges(&self, n: N) -> impl Iterator<Item = (&StaticEdge<N>, &StaticNode<N>)> { |
Contributor
There was a problem hiding this comment.
Do we also want an in_edges method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respin of #2531, marking the node/edge enums in the new StaticGraph as
non-exhaustiveand adding Consts + LoadConstants.(Lukas originally planned to make something like this to reflect references from Terms to functions, and non-exhaustive allows extending this StaticGraph for that purpose - if we do go that way, however, I have a different plan, can describe if relevant. Rather I think non-exhaustive is just a reasonable allowance for future extension to new use-cases hopefully without damaging existing use-cases.)
This is taken from #2555, i.e. which uses it (although there it is still called CallGraph in hugr-core).
Naming: could be ModuleGraph ?? Other ideas welcome.
I will add a test with some Consts + use of
out_edges(tho will be supplied in #2555 !)