Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat error with LinearOperatorCOllection v1.2.0 #5

Open
aTrotier opened this issue Mar 13, 2024 · 4 comments
Open

Compat error with LinearOperatorCOllection v1.2.0 #5

aTrotier opened this issue Mar 13, 2024 · 4 comments

Comments

@aTrotier
Copy link
Member

aTrotier commented Mar 13, 2024

The API to LinearOperatorCollection.il had changed in the most recent version (V1.2.0).
Therefore, in reconstruction multiCoilMultiEcho subspace (IterativeReconstruction.il)
the call to Weighting Op on L374 returns a "MethodError: no method matching" error. This is because a ";" is missing from the WeightingOp function definition in WeightingOp.jl (LinearOperatorCollection.jl), and so the keyword arguments are unsupported in LinearOperatorCollection.jl V1.2.0
By Downgrading to V1.1.2, I was able to run the code sucessfully

The author's own code appeared to run entirely as expected and without issues.

linked to JuliaImageRecon/LinearOperatorCollection.jl#7

@aTrotier
Copy link
Member Author

aTrotier commented Mar 13, 2024

The API was changed between my last test and the review.

A compat entry to LinearOperatorCollection will be added and the manifest to generate the figure will be stored in the docs folder for reproducibility purpose.

@aTrotier
Copy link
Member Author

aTrotier commented Mar 13, 2024

@wtclarke I guess that you reviewed my package. If it is the case, thanks for the time you take to make it works and for the the comments 👍

If you have time, can you try to reproduce the figure with the release 1.0.1.
I have pin the version to "=1.1.2" in the package and I have also put my Manifest.toml in the docs folder.

If you launch julia in the docs folder julia --project -t auto and run

using Pkg
Pkg.instantiate()

It should always use the same version of the packages.

PS : for the CairoMakie missing package, I think you were not using the Project.toml in docs, it was not clear in the readme. I have added a sentence about that.

@wtclarke
Copy link

You guessed correctly. ;)

It seems to work now, though I'm not entirely sure I'm working with a clean environment now. Is there a way to ensure that?

Yes, I hadn't gathered I had to run from within the docs folder, though I should have guessed from the path.

@aTrotier
Copy link
Member Author

I think you can delete the Manifest.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants