Skip to content

Commit 1ccb7ea

Browse files
authored
Merge pull request #32 from CSolanaM/release/1.0.6
[SU-RELEASE] 1.0.6
2 parents af57c38 + b6e88b5 commit 1ccb7ea

File tree

5 files changed

+18
-7
lines changed

5 files changed

+18
-7
lines changed

Diff for: .github/FUNDING.yml

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
github: [CSolanaM]

Diff for: CHANGELOG.md

+10
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
# Change Log
22
All notable changes to this project will be documented in this file.
33

4+
## [1.0.6](https://github.com/CSolanaM/SkeletonUI/releases/tag/1.0.6)
5+
### Added
6+
-
7+
### Changed
8+
-
9+
### Removed
10+
-
11+
### Fixed
12+
- Renamed `TextField`'s `OptionalType` extension initializer signature to avoid conflicts.
13+
414
## [1.0.5](https://github.com/CSolanaM/SkeletonUI/releases/tag/1.0.5)
515
### Added
616
-

Diff for: SkeletonUI.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'SkeletonUI'
3-
s.version = '1.0.5'
3+
s.version = '1.0.6'
44
s.summary = 'Elegant skeleton loading animation in SwiftUI and Combine'
55
s.description = <<-DESC
66
SkeletonUI aims to bring an elegant, declarative syntax to skeleton loading animations. Get rid of loading screens or spinners and start using skeletons to represent final content shapes

Diff for: Sources/SkeletonUI/Extensions/TextField+OptionalType.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import SwiftUI
22

33
public extension TextField where Label == Text {
4-
init(_ titleKey: LocalizedStringKey?, text: Binding<String>, onEditingChanged: @escaping (Bool) -> Void = { _ in }, onCommit: @escaping () -> Void = {}) {
4+
init(titleKey: LocalizedStringKey?, text: Binding<String>, onEditingChanged: @escaping (Bool) -> Void = { _ in }, onCommit: @escaping () -> Void = {}) {
55
if let titleKey = titleKey {
66
self.init(titleKey, text: text, onEditingChanged: onEditingChanged, onCommit: onCommit)
77
} else {
@@ -17,7 +17,7 @@ public extension TextField where Label == Text {
1717
}
1818
}
1919

20-
init<T>(_ titleKey: LocalizedStringKey?, value: Binding<T>, formatter: Formatter, onEditingChanged: @escaping (Bool) -> Void = { _ in }, onCommit: @escaping () -> Void = {}) {
20+
init<T>(titleKey: LocalizedStringKey?, value: Binding<T>, formatter: Formatter, onEditingChanged: @escaping (Bool) -> Void = { _ in }, onCommit: @escaping () -> Void = {}) {
2121
if let titleKey = titleKey {
2222
self.init(titleKey, value: value, formatter: formatter, onEditingChanged: onEditingChanged, onCommit: onCommit)
2323
} else {

Diff for: Tests/SkeletonUISnapshotTests/SnapshotTests.swift

+4-4
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@ final class SnapshotTests: XCTestCase {
6666
}
6767

6868
func testDefaultTextField() {
69-
let one = TextField(nil, text: Binding.constant(String())).skeleton(with: true)
70-
let two = TextField(nil, value: Binding.constant(String()), formatter: NumberFormatter()).skeleton(with: true)
69+
let one = TextField(titleKey: nil, text: Binding.constant(String())).skeleton(with: true)
70+
let two = TextField(titleKey: nil, value: Binding.constant(String()), formatter: NumberFormatter()).skeleton(with: true)
7171
assertNamedSnapshot(matching: one, as: .image(size: CGSize(width: 100, height: 50)))
7272
assertNamedSnapshot(matching: two, as: .image(size: CGSize(width: 100, height: 50)))
7373
}
7474

7575
func testCustomTextField() {
76-
let one = TextField(nil, text: Binding.constant(String())).skeleton(with: true).appearance(type: .gradient(.angular)).shape(type: .ellipse)
77-
let two = TextField(nil, value: Binding.constant(String()), formatter: NumberFormatter()).skeleton(with: true).appearance(type: .gradient(.angular)).shape(type: .ellipse)
76+
let one = TextField(titleKey: nil, text: Binding.constant(String())).skeleton(with: true).appearance(type: .gradient(.angular)).shape(type: .ellipse)
77+
let two = TextField(titleKey: nil, value: Binding.constant(String()), formatter: NumberFormatter()).skeleton(with: true).appearance(type: .gradient(.angular)).shape(type: .ellipse)
7878
assertNamedSnapshot(matching: one, as: .image(size: CGSize(width: 100, height: 50)))
7979
assertNamedSnapshot(matching: two, as: .image(size: CGSize(width: 100, height: 50)))
8080
}

0 commit comments

Comments
 (0)