Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #164: Enhance and fix WebActivity as default to display webpages #185

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix #164: Enhance and fix WebActivity as default to display webpages #185

wants to merge 7 commits into from

Conversation

GowthamGoush
Copy link
Contributor

@GowthamGoush GowthamGoush commented Apr 28, 2021 •
edited
Loading

Explanation

Fixes #164:

  • Made Job Portal open inside web activity.
  • Enhanced web activity with a toolbar.
  • Added option to close, open desktop site and open zoom controls under the toolbar.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adher to the contributing guidelines of the project.
  • The PR is made to the branch that's called "develop".
  • The PR is made from a branch that is up-to-date with "develop".

riturajjain2000
riturajjain2000 requested changes Apr 29, 2021
View reviewed changes
Copy link
Member

@riturajjain2000 riturajjain2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user clicks on the desktop site and wants to go again to mobile mode, there is no option
Also, the usage of zoom functionality is confusing as it not available whether the options are available or not

SO,

  • Remove the menu and the "CS wala" text from the Action bar, keep it empty
  • Use a Toggle switch at the left bottom of the screen
  • Remove the zoomcontrols as they are deprecated in API 26

@GowthamGoush
Copy link
Contributor Author

Alright, I'll make those changes. Also, I just failed to mention that the desktop view wasn't working for me even after referring to the documentation and articles. Could you mention some resources, or shall I place a dummy toggle button as of now?

@riturajjain2000
Copy link
Member

Alright, I'll make those changes. Also, I just failed to mention that the desktop view wasn't working for me even after referring to the documentation and articles. Could you mention some resources, or shall I place a dummy toggle button as of now?

OK I'll share the resources

@riturajjain2000
Copy link
Member

riturajjain2000 commented Apr 30, 2021 •
edited
Loading

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1

Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

@GowthamGoush
Copy link
Contributor Author

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1

Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

Extremely sorry for the delay. I followed what you had mentioned above, but still, it didn't work for me. I just wish to know if this not worked for me alone.

@riturajjain2000
Copy link
Member

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1
Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

Extremely sorry for the delay. I followed what you had mentioned above, but still, it didn't work for me. I just wish to know if this not worked for me alone.

I did not tried it , but this is the best available solution I found on the net

@GowthamGoush
Copy link
Contributor Author

As of now, shall I skip this and implement the rest of the features?

@riturajjain2000
Copy link
Member

riturajjain2000 commented May 8, 2021 •
edited
Loading

As of now, shall I skip this and implement the rest of the features?

Ok leave the PR as it is , I'll merge it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riturajjain2000 riturajjain2000 riturajjain2000 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job Portal's should open inside app
2 participants
@GowthamGoush @riturajjain2000