Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job Portal's should open inside app #164

Open
riturajjain2000 opened this issue Apr 17, 2021 · 6 comments · May be fixed by #185
Open

Job Portal's should open inside app #164

riturajjain2000 opened this issue Apr 17, 2021 · 6 comments · May be fixed by #185
Assignees
@GowthamGoush

Comments

@riturajjain2000
Copy link
Member

The career pages from the portal's section are opening in browser as of now , they should open inside the app's websview only
@riturajjain2000 riturajjain2000 added code-enhancement Enhancing code readability and usability gssoc21 For GSSOC 21 Level2 issue with intermediate difficulty labels Apr 17, 2021
@GowthamGoush
Copy link
Contributor

Shall we make use of the pre-existing WebActivity for this?

@riturajjain2000
Copy link
Member Author

Yeah it should open there only

@GowthamGoush
Copy link
Contributor

Cool. I'll take this issue.

@GowthamGoush
Copy link
Contributor

Fixing this was simple, so may I add enhancement to the web activity? It may be like adding an option to exit the webview without the actual need to press the back button. Also, I'll be glad to hear any suggestions from you.

@riturajjain2000
Copy link
Member Author

ok go ahead , also see if you can add the "see as desktop site functionality" , like in chrome there is this feature which is very helpful

@GowthamGoush
Copy link
Contributor

Yeah, sure, I'll try that too.

@GowthamGoush GowthamGoush linked a pull request Apr 28, 2021 that will close this issue
Open
7 tasks
@riturajjain2000 riturajjain2000 added code-enhancement Enhancing code readability and usability and removed Level2 issue with intermediate difficulty gssoc21 For GSSOC 21 code-enhancement Enhancing code readability and usability labels Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GowthamGoush GowthamGoush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #164: Enhance and fix WebActivity as default to display webpages GowthamGoush/CSwala-android
2 participants
@riturajjain2000 @GowthamGoush