-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates to LightningCLI #265
Draft
kylebgorman
wants to merge
19
commits into
CUNY-CL:master
Choose a base branch
from
kylebgorman:cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes CUNY-CL#60. Closes CUNY-CL#218. LightningCLI removes our need to create separate training and prediction CLI programs, moving nearly all of that logic into the base model. This commit in particular sets the stage: * Updates dependencies. * Increments minor version number. * Creates an empty `cli.py` where the CLI-speific logic will live.
This adds an extra flag to every command and for what? If you want to keep model directories separate for different experiments in a way that goes beyond already done with the automated versioning, you can just append a subdirectory name to `--model_dir`, e.g., using `--model_dir models/foo` instead of `--model_dir models --experiment foo`.
Borrowing a design element I used in UDTube, I decompose the dataset object into two pieces: * a `Mapper` interface which knows how to map between lists of strings and tensors (to decode and encode) * `DataSet`, as before There was no particular reason for the mapper functions to live inside the dataset, and this commit simply makes this separation. A subsequent commit will use this mapper object during prediction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60.
Closes #218.
LightningCLI removes our need to create separate training and prediction CLI programs, moving nearly all of that logic into the base model.
This commit in particular sets the stage:
cli.py
where the CLI-speific logic will live.