Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra Config File Support (Post LightningCLI integration) #232

Open
bonham79 opened this issue Aug 2, 2024 · 6 comments
Open

Hydra Config File Support (Post LightningCLI integration) #232

bonham79 opened this issue Aug 2, 2024 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@bonham79
Copy link
Collaborator

bonham79 commented Aug 2, 2024

LightningCLI supports YAML configs. However we're going to need to add some additional OmegaConf and Hydra support to our existing scripts to best utilize this. This issue will work on full integration of LightningCLI post PTL 2. Also creates YAML files to document base files.

@bonham79 bonham79 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 2, 2024
@bonham79 bonham79 self-assigned this Aug 2, 2024
@kylebgorman
Copy link
Contributor

Migrating to PTL 2 and its LightningCLI interface (#60) also gives us configuration file support.

@bonham79
Copy link
Collaborator Author

bonham79 commented Aug 6, 2024

@kylebgorman
Copy link
Contributor

kylebgorman commented Aug 6, 2024 via email

@bonham79
Copy link
Collaborator Author

bonham79 commented Aug 6, 2024

Hydra is used for command line processing of YAML configs and OmegaConf is used for Python processing of YAML configs. So those would be the backend. However, we're still going to need to instantiate our own idiosyncratic way of using them.

At base, we can keep this issue up as a reminder to create YAML config files for every base model we have. I'll rename accordingly.

@bonham79 bonham79 changed the title Hydra Config Files Hydra Config File Support (Post LightningCLI integration) Aug 6, 2024
@kylebgorman
Copy link
Contributor

kylebgorman commented Aug 6, 2024 via email

@bonham79
Copy link
Collaborator Author

bonham79 commented Aug 6, 2024

It has pros and cons. But our argument parser is getting a bit unwieldy so the alternative would be easier on our eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants