-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydra Config File Support (Post LightningCLI integration) #232
Comments
Migrating to PTL 2 and its LightningCLI interface (#60) also gives us configuration file support. |
The two go together. LightningCLI builds off Hydra and OmegaConf: |
Are the lightingcli YAML files instances of Hydra or OmegaConf files?Basically what I want to know is whether, if we migrate to LightningCLI, this issue is complete or there is subsequent work needed to add support for these other tools.On Aug 6, 2024, at 12:32 PM, Travis Bartley ***@***.***> wrote:
The two go together. LightningCLI builds off Hydra and OmegaConf:
https://github.com/Lightning-AI/pytorch-lightning/blob/cf24a190ce52d65ae7316fceec584145f1e1f006/requirements/pytorch/extra.txt#L7-L8
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Hydra is used for command line processing of YAML configs and OmegaConf is used for Python processing of YAML configs. So those would be the backend. However, we're still going to need to instantiate our own idiosyncratic way of using them. At base, we can keep this issue up as a reminder to create YAML config files for every base model we have. I'll rename accordingly. |
Thanks for clarification; I think a successful completion of the migration to PTL 2 will have this as a side effect but let’s keep this open to make sure we’re happy with config file support. I much prefer config files over Bash for this kind of thing, sounds like you too.On Aug 6, 2024, at 12:55 PM, Travis Bartley ***@***.***> wrote:
Hydra is used for command line processing of YAML configs and OmegaConf is used for Python processing of YAML configs. So those would be the backend. However, we're still going to need to instantiate our own idiosyncratic way of using them.
At base, we can keep this issue up as a reminder to create YAML config files for every base model we have. I'll rename accordingly.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
It has pros and cons. But our argument parser is getting a bit unwieldy so the alternative would be easier on our eyes. |
LightningCLI supports YAML configs. However we're going to need to add some additional OmegaConf and Hydra support to our existing scripts to best utilize this. This issue will work on full integration of LightningCLI post PTL 2. Also creates YAML files to document base files.
The text was updated successfully, but these errors were encountered: