Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EditAction Behavior to Indexes #248

Open
bonham79 opened this issue Sep 15, 2024 · 1 comment
Open

Move EditAction Behavior to Indexes #248

bonham79 opened this issue Sep 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@bonham79
Copy link
Collaborator

With #247, most of the work in instantiating edit actions for the transducer is coming from the Index. It would make more sense to just make this inherited behavior from the Index class and create a new 'ActionIndex` class that takes over all behavior related to edit action creation. This would allow the target_vocabulary related behavior for the transducer to be managed at index creation, instead of adding hacks in the train and model code.

I'm also gonna sneak in potential changes to the expert class that trains the SED when creating the dataloader, allowing us to only iterate through the train set once. With enough code moved around, the expert class can be changed to a mixin (which I'll handle in a separate PR.)

@bonham79 bonham79 self-assigned this Sep 15, 2024
@bonham79 bonham79 added bug Something isn't working enhancement New feature or request labels Sep 15, 2024
@bonham79
Copy link
Collaborator Author

@kylebgorman with the new prs in i'm going to work on this over the weekend so we can clear up more of these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant