You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #247, most of the work in instantiating edit actions for the transducer is coming from the Index. It would make more sense to just make this inherited behavior from the Index class and create a new 'ActionIndex` class that takes over all behavior related to edit action creation. This would allow the target_vocabulary related behavior for the transducer to be managed at index creation, instead of adding hacks in the train and model code.
I'm also gonna sneak in potential changes to the expert class that trains the SED when creating the dataloader, allowing us to only iterate through the train set once. With enough code moved around, the expert class can be changed to a mixin (which I'll handle in a separate PR.)
The text was updated successfully, but these errors were encountered:
With #247, most of the work in instantiating edit actions for the transducer is coming from the Index. It would make more sense to just make this inherited behavior from the Index class and create a new 'ActionIndex` class that takes over all behavior related to edit action creation. This would allow the target_vocabulary related behavior for the transducer to be managed at index creation, instead of adding hacks in the train and model code.
I'm also gonna sneak in potential changes to the expert class that trains the SED when creating the dataloader, allowing us to only iterate through the train set once. With enough code moved around, the expert class can be changed to a mixin (which I'll handle in a separate PR.)
The text was updated successfully, but these errors were encountered: