Use level's configured sea height for chunk mesh estimation heuristics (#3241)

Previously the code assumed the sea height was always y=62.

Author: douira

common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/RenderSectionManager.java

@@ -76,7 +76,7 @@ public class RenderSectionManager {
 
     private final ConcurrentLinkedDeque<ChunkJobResult<? extends BuilderTaskOutput>> buildResults = new ConcurrentLinkedDeque<>();
     private final JobDurationEstimator jobDurationEstimator = new JobDurationEstimator();
-    private final MeshTaskSizeEstimator meshTaskSizeEstimator = new MeshTaskSizeEstimator();
+    private final MeshTaskSizeEstimator meshTaskSizeEstimator;
     private final UploadDurationEstimator jobUploadDurationEstimator = new UploadDurationEstimator();
     private ChunkJobCollector lastBlockingCollector;
     private int thisFrameBlockingTasks;
@@ -116,6 +116,8 @@ public class RenderSectionManager {
     private final RemovableMultiForest renderableSectionTree;
 
     public RenderSectionManager(ClientLevel level, int renderDistance, SortBehavior sortBehavior, CommandList commandList) {
+        this.meshTaskSizeEstimator = new MeshTaskSizeEstimator(level);
+        
         this.chunkRenderer = new DefaultChunkRenderer(RenderDevice.INSTANCE, ChunkMeshFormats.COMPACT);
 
         this.level = level;
@@ -386,7 +388,7 @@ private boolean processChunkBuildResults(ArrayList<BuilderTaskOutput> results) {
                 touchedSectionInfo |= this.updateSectionInfo(result.render, chunkBuildOutput.info);
 
                 result.render.setLastMeshResultSize(resultSize);
-                this.meshTaskSizeEstimator.addData(MeshResultSize.forSection(result.render, resultSize));
+                this.meshTaskSizeEstimator.addData(this.meshTaskSizeEstimator.resultForSection(result.render, resultSize));
 
                 if (chunkBuildOutput.translucentData != null) {
                     this.sortTriggering.integrateTranslucentData(oldData, chunkBuildOutput.translucentData, this.cameraPosition, this::scheduleSort);

common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/compile/estimation/MeshResultSize.java

@@ -12,26 +12,29 @@ public enum SectionCategory {
         SURFACE,
         HIGH;
 
-        public static SectionCategory forSection(RenderSection section) {
+        public static SectionCategory forSection(RenderSection section, int seaLevelChunk) {
             var sectionY = section.getChunkY();
-            if (sectionY < 0) {
+            
+            // Roughly classify type of chunk based on Y level relative to sea level:
+            // Water level chunks are likely to have different meshes from those below and those above.
+            // Very low chunks are again different because they aren't going to include the underwater terrain (just caves).
+            // Very high chunks are (at least locally) different because they are likely to be mostly air with some terrain poking through, or just buildings/jungle tree tops.
+            if (sectionY == seaLevelChunk) {
+                return WATER_LEVEL;
+            }
+            if (sectionY < seaLevelChunk - 4) {
                 return LOW;
-            } else if (sectionY < 3) {
+            }
+            if (sectionY < seaLevelChunk) {
                 return UNDERGROUND;
-            } else if (sectionY == 3) {
-                return WATER_LEVEL;
-            } else if (sectionY < 7) {
+            }
+            if (sectionY < seaLevelChunk + 3) {
                 return SURFACE;
-            } else {
-                return HIGH;
             }
+            return HIGH;
         }
     }
 
-    public static MeshResultSize forSection(RenderSection section, long resultSize) {
-        return new MeshResultSize(SectionCategory.forSection(section), resultSize);
-    }
-
     @Override
     public SectionCategory category() {
         return this.category;

common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/compile/estimation/MeshTaskSizeEstimator.java

@@ -2,23 +2,32 @@
 
 import net.caffeinemc.mods.sodium.client.render.chunk.RenderSection;
 import net.caffeinemc.mods.sodium.client.render.chunk.region.RenderRegion;
+import net.minecraft.client.Minecraft;
+import net.minecraft.client.multiplayer.ClientLevel;
 
 import java.util.EnumMap;
 import java.util.Map;
 
 public class MeshTaskSizeEstimator extends Average1DEstimator<MeshResultSize.SectionCategory> {
     public static final float NEW_DATA_RATIO = 0.02f;
+    
+    private final int seaLevelChunk;
 
-    public MeshTaskSizeEstimator() {
+    public MeshTaskSizeEstimator(ClientLevel level) {
         super(NEW_DATA_RATIO, RenderRegion.SECTION_BUFFER_ESTIMATE);
+        this.seaLevelChunk = level.getSeaLevel() >> 4;
     }
 
     public long estimateSize(RenderSection section) {
         var lastResultSize = section.getLastMeshResultSize();
         if (lastResultSize != MeshResultSize.NO_DATA) {
             return lastResultSize;
         }
-        return this.predict(MeshResultSize.SectionCategory.forSection(section));
+        return this.predict(MeshResultSize.SectionCategory.forSection(section, this.seaLevelChunk));
+    }
+    
+    public MeshResultSize resultForSection(RenderSection section, long resultSize) {
+        return new MeshResultSize(MeshResultSize.SectionCategory.forSection(section, this.seaLevelChunk), resultSize);
     }
 
     @Override