Alloy FPS: Don't send extended packet, increase time between packets to 10ms to eliminate flickering

Author: CalcProgrammer1

Controllers/HyperXKeyboardController/HyperXAlloyFPSController.cpp

@@ -139,28 +139,21 @@ void HyperXAlloyFPSController::SetLEDsDirect(std::vector<RGBColor> colors)
         red_color_data
         );
 
-    std::this_thread::sleep_for(5ms);
+    std::this_thread::sleep_for(10ms);
 
     SendDirect
         (
         HYPERX_ALLOY_FPS_COLOR_CHANNEL_GREEN,
         grn_color_data
         );
 
-    std::this_thread::sleep_for(5ms);
+    std::this_thread::sleep_for(10ms);
 
     SendDirect
         (
         HYPERX_ALLOY_FPS_COLOR_CHANNEL_BLUE,
         blu_color_data
         );
-
-    std::this_thread::sleep_for(5ms);
-
-    SendDirectExtended
-        (
-        ext_color_data
-        );
 }
 
 void HyperXAlloyFPSController::SetLEDs(std::vector<RGBColor> colors)
@@ -201,14 +194,6 @@ void HyperXAlloyFPSController::SetLEDs(std::vector<RGBColor> colors)
         HYPERX_ALLOY_FPS_COLOR_CHANNEL_BLUE,
         blu_color_data
         );
-
-    std::this_thread::sleep_for(5ms);
-    
-    SendExtendedColor
-        (
-        0x01,
-        ext_color_data
-        );
 }
 
 /*-------------------------------------------------------------------------------------------------*\
@@ -381,33 +366,6 @@ void HyperXAlloyFPSController::SendColor
     hid_send_feature_report(dev, buf, 264);
 }
 
-void HyperXAlloyFPSController::SendExtendedColor
-    (
-    unsigned char   profile,
-    unsigned char*  color_data
-    )
-{
-    unsigned char buf[264];
-
-    /*-----------------------------------------------------*\
-    | Zero out buffer                                       |
-    \*-----------------------------------------------------*/
-    memset(buf, 0x00, sizeof(buf));
-
-    /*-----------------------------------------------------*\
-    | Set up Color packet                                   |
-    \*-----------------------------------------------------*/
-    buf[0x00]   = 0x07;
-    buf[0x01]   = HYPERX_ALLOY_FPS_PACKET_ID_SET_COLOR;
-    buf[0x02]   = profile;
-    buf[0x03]   = HYPERX_ALLOY_FPS_COLOR_CHANNEL_EXTENDED;
-
-    /*-----------------------------------------------------*\
-    | Send packet                                           |
-    \*-----------------------------------------------------*/
-    hid_send_feature_report(dev, buf, 264);
-}
-
 void HyperXAlloyFPSController::SendDirect
     (
     unsigned char   color_channel,
@@ -441,30 +399,4 @@ void HyperXAlloyFPSController::SendDirect
     | Send packet                                           |
     \*-----------------------------------------------------*/
     hid_send_feature_report(dev, buf, 264);
-}
-
-void HyperXAlloyFPSController::SendDirectExtended
-    (
-    unsigned char*  color_data
-    )
-{
-    unsigned char buf[264];
-
-    /*-----------------------------------------------------*\
-    | Zero out buffer                                       |
-    \*-----------------------------------------------------*/
-    memset(buf, 0x00, sizeof(buf));
-
-    /*-----------------------------------------------------*\
-    | Set up Direct packet                                  |
-    \*-----------------------------------------------------*/
-    buf[0x00]   = 0x07;
-    buf[0x01]   = HYPERX_ALLOY_FPS_PACKET_ID_DIRECT;
-    buf[0x02]   = HYPERX_ALLOY_FPS_COLOR_CHANNEL_EXTENDED;
-    buf[0x03]   = 0xA0;
-
-    /*-----------------------------------------------------*\
-    | Send packet                                           |
-    \*-----------------------------------------------------*/
-    hid_send_feature_report(dev, buf, 264);
-}
+}

Controllers/HyperXKeyboardController/HyperXAlloyFPSController.h

@@ -58,8 +58,7 @@ enum
 {
     HYPERX_ALLOY_FPS_COLOR_CHANNEL_RED              = 0x01,
     HYPERX_ALLOY_FPS_COLOR_CHANNEL_GREEN            = 0x02,
-    HYPERX_ALLOY_FPS_COLOR_CHANNEL_BLUE             = 0x03,
-    HYPERX_ALLOY_FPS_COLOR_CHANNEL_EXTENDED         = 0x04
+    HYPERX_ALLOY_FPS_COLOR_CHANNEL_BLUE             = 0x03
 };
 
 class HyperXAlloyFPSController
@@ -120,20 +119,9 @@ class HyperXAlloyFPSController
                 unsigned char*  color_data
                 );
 
-    void    SendExtendedColor
-                (
-                unsigned char   profile,
-                unsigned char*  color_data
-                );
-
     void    SendDirect
                 (
                 unsigned char   color_channel,
                 unsigned char*  color_data
                 );
-
-    void    SendDirectExtended
-                (
-                unsigned char*  color_data
-                );
 };