Skip to content

Commit

Permalink
Release 12.1.0 (#420)
Browse files Browse the repository at this point in the history
* prepare next development version 12.0.1-SNAPSHOT

* Fix ref in replace views w/ `findOrAddObject()`

Fixes #402

See GitHub issue for in-depth analysis and testing results.

* Add missing dist files

* Use context to get current view name

Fixes #254

* Remove `nav.mainNavi` styles (#415)

I couldn't find any occurence or usage of the CSS class `mainNavi` in the TypeScript code of the phovea, Caleydo, or datavisyn organization, nor do know where this element would be. Hence, I would remove this code.

* Prepare github changes

* Remove circleci

* prepare release_12.1.0

Co-authored-by: Holger Stitz <[email protected]>
Co-authored-by: Champari Oltion <[email protected]>
Co-authored-by: Dominic Girardi <[email protected]>
Co-authored-by: anita-steiner <>
  • Loading branch information
4 people authored Aug 4, 2022
1 parent 9fc30b6 commit 456b054
Show file tree
Hide file tree
Showing 21 changed files with 114 additions and 500 deletions.
59 changes: 0 additions & 59 deletions .circleci/config.yml

This file was deleted.

1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* @thinkh

Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: 'type: bug'
assignees: ''
name: 🐛Bug Report
about: Create a bug report to help us improve
title: ""
labels: ["type: bug"]
assignees: ""

---

Expand All @@ -12,6 +12,7 @@ assignees: ''
* Release number or git hash:
* Browser:
* Deployed / Local:
---

### Steps to reproduce the bug

Expand All @@ -30,3 +31,6 @@ assignees: ''
### Expected Behavior

> Please provide a short description which behavior you expected from your steps
Thanks for taking the time to fill out this bug report 🤗
Make sure there aren't any open/closed issues for this topic 😃
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
name: ✨Feature Request
about: Request a new feature or enhancement
title: ""
labels: ["type: feature"]
---

## Short description

Please provide a short description which summarizes the idea behind this feature request and why this is useful.

## User stories

* As a *user*, I want to ... so that ...


Please make sure this feature request hasn't been already submitted by someone by looking through other open/closed issues 😃
20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

27 changes: 0 additions & 27 deletions .github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

45 changes: 45 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
Closes *list issues numbers here*

### Developer Checklist (Definition of Done)

**Issue**

- [ ] All acceptance criteria from the issue are met
- [ ] Tested in latest Chrome/Firefox

**UI/UX/Vis**

- [ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (_tag assignees_)
- [ ] Review has occurred (_link to notes_)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

**Code**

- [ ] Branch is up-to-date with the branch to be merged with, i.e., develop
- [ ] Code is cleaned up and formatted
- [ ] Unit tests are written (frontend/backend if applicable)
- [ ] Integration tests are written (if applicable)

**PR**

- [ ] Descriptive title for this pull request is provided (will be used for release notes later)
- [ ] Reviewer and assignees are defined
- [ ] Add type label (e.g., *bug*, *feature*) to this pull request
- [ ] Add release label (e.g., `release: minor`) to this PR following [semver](https://semver.org/)
- [ ] The PR is connected to the corresponding issue (via `Closes #...`)
- [ ] [Summary of changes](#summary-of-changes) is written


### Summary of changes

-

### Screenshots


### Additional notes for the reviewer(s)

-
Thanks for creating this pull request 🤗
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: build

on: [push, workflow_dispatch]

jobs:
build:
uses: datavisyn/github-workflows/.github/workflows/build-node.yml@main
secrets: inherit
8 changes: 8 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: publish

on: workflow_dispatch

jobs:
publish:
uses: datavisyn/github-workflows/.github/workflows/publish-node.yml@main
secrets: inherit
8 changes: 8 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: release

on: workflow_dispatch

jobs:
release:
uses: datavisyn/github-workflows/.github/workflows/release-source.yml@main
secrets: inherit
2 changes: 1 addition & 1 deletion dist/internal/ViewWrapper.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/internal/ViewWrapper.js.map

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions dist/internal/cmds.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/internal/cmds.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion dist/internal/cmds.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 456b054

Please sign in to comment.