Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Refactor stylesheets organization and imports #153

Merged
5 commits merged into from
Dec 28, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Dec 1, 2020

Closes #152

Summary

  • Split main.scss into multiple files
  • Remove scss import from TS files

Make sure to switch back the branches after merging

How to test

Tested with this workspace.scss:

@debug('import plugin scss variables');
// import all variables scss
// first default app
@import "~taco/dist/scss/abstracts/variables";
// then going up in the dependency tree from the default app
@import "~phovea_ui/dist/scss/abstracts/variables";
// then all other plugins in this workspace (excluding other apps)
@import "~font-awesome/scss/variables";

// import mixins
@import "~font-awesome/scss/mixins";

@debug('import plugin main scss');
// all main scss (in opposite order of the variables scss
@import "~phovea_ui/dist/scss/main";
@import "~taco/dist/scss/main";

@thinkh thinkh added type: refactor Refactor the current implementation type: technical debt Describes or removes a technical debt labels Dec 1, 2020
@thinkh thinkh linked an issue Dec 1, 2020 that may be closed by this pull request
@ghost ghost marked this pull request as ready for review December 28, 2020 13:34
@ghost ghost merged commit 87d21ee into develop Dec 28, 2020
@ghost ghost deleted the dmoitzi/refactor_stylesheets_organiation_and_imports branch December 28, 2020 13:36
@dvvanessastoiber dvvanessastoiber mentioned this pull request Jan 28, 2021
2 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Refactor the current implementation type: technical debt Describes or removes a technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor stylesheets organization and imports
1 participant