Towards 100% test coverage

Author: trinitytakei

.cursorrules

@@ -166,3 +166,15 @@ logger.warn takes ONE string parameter - if you want to add data to the message,
 # 2. If jobs are there but not being processed, try restarting the Rails server
 # 3. This usually indicates the Puma plugin for Solid Queue got into a bad state
 # 4. A restart will reinitialize everything cleanly
+
+# When stubbing File.exist? in tests, make sure to stub ALL possible File.exist? calls that could happen
+# during the test execution, not just the ones you're directly testing. Partial stubbing can lead to
+# flaky tests that depend on the filesystem state.
+#
+# Use this pattern:
+# 1. Stub all File.exist? calls to return false by default:
+#    File.stubs(:exist?).returns(false)
+# 2. Then override specific paths you care about:
+#    File.stubs(:exist?).with("specific/path.rb").returns(true)
+# 3. Use regex for paths that might be absolute/relative:
+#    File.stubs(:exist?).with(regexp_matches(/config\/routes\.rb\z/)).returns(true)

test/services/app_generation/orchestrator_test.rb

@@ -126,7 +126,11 @@ class OrchestratorTest < ActiveSupport::TestCase
       data_repository = mock("data_repository")
       data_repository.stubs(:template_path).returns("/nonexistent/path/template.rb")
       DataRepositoryService.stubs(:new).with(user: @generated_app.user).returns(data_repository)
+      # Stub all File.exist? calls to return false by default
+      File.stubs(:exist?).returns(false)
+      # Then override specific paths we care about
       File.stubs(:exist?).with("/nonexistent/path/template.rb").returns(false)
+      File.stubs(:exist?).with(regexp_matches(/config\/routes\.rb\z/)).returns(false)
 
       # Expect proper logging
       sequence = sequence("error_logging")

test/services/local_git_service_test.rb

@@ -160,6 +160,33 @@ def setup
     @service.prepare_git_repository(remote_url:)
   end
 
+  test "ensure_main_branch renames current branch to main" do
+    @service.expects(:run_command).with("git branch -M main")
+    @service.ensure_main_branch
+  end
+
+  test "ensure_main_branch integration test - actually renames branch to main" do
+    # Initialize a git repo with a non-main branch
+    @service.in_working_directory do
+      Open3.capture2("git init --quiet")
+      Open3.capture2("git config user.name 'Test User'")
+      Open3.capture2("git config user.email 'test@example.com'")
+      Open3.capture2("git checkout -b master --quiet")  # Create master branch
+      Open3.capture2("git commit --allow-empty -m 'Initial commit' --quiet")
+    end
+
+    # Run the actual method
+    @service.ensure_main_branch
+
+    # Verify the branch was renamed
+    current_branch = nil
+    @service.in_working_directory do
+      current_branch = Open3.capture2("git rev-parse --abbrev-ref HEAD")[0].strip
+    end
+
+    assert_equal "main", current_branch
+  end
+
   test "raises error when preparing repository in non-existent directory" do
     service = LocalGitService.new(working_directory: "/nonexistent", logger: @logger)