Refactoring: checkbox -> rails_flag_checkbox

Author: trinitytakei

app/javascript/controllers/check_box_controller.js

@@ -0,0 +1,28 @@
+import { Controller } from "@hotwired/stimulus"
+
+// Handles the Rails flag checkboxes in the UI
+export default class extends Controller {
+  static targets = ["output"]
+
+  connect() {
+    this.groupElement = this.element.closest('ul')
+    if (!this.groupElement) return
+    this.update()
+  }
+
+  update() {
+    const checkboxes = this.groupElement.querySelectorAll('input[type="checkbox"]')
+    const selectedValues = Array.from(checkboxes)
+      .filter(checkbox => {
+        const displayWhen = checkbox.dataset.displayWhen || 'checked'
+        const isChecked = checkbox.checked
+        return (displayWhen === 'checked' && isChecked) ||
+               (displayWhen === 'unchecked' && !isChecked)
+      })
+      .map(checkbox => checkbox.dataset.commandOutput)
+      .filter(Boolean)
+
+    const outputElement = document.getElementById('rails-flags')
+    outputElement.textContent = selectedValues.join(" ")
+  }
+}

app/javascript/controllers/rails_flag_checkbox_controller.js

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GroupBehavior
   extend ActiveSupport::Concern
 
@@ -15,13 +17,13 @@ def stimulus_attributes
       }
     when "generic_checkbox"
       {
-        controller: "check-box",
-        "check-box-generated-output-outlet": "#rails-flags"
+        controller: "rails-flag-checkbox",
+        "rails-flag-checkbox-generated-output-outlet": "#rails-flags"
       }
     when "custom_ingredient_checkbox"
       {
-        controller: "check-box",
-        "check-box-generated-output-outlet": "#custom_ingredients"
+        controller: "rails-flag-checkbox",
+        "rails-flag-checkbox-generated-output-outlet": "#custom_ingredients"
       }
     else
       {}

app/models/concerns/group_behavior.rb

@@ -32,15 +32,17 @@ class Element < ApplicationRecord
   before_save :set_command_line_value
 
   delegated_type :variant, types: %w[
-    Element::Checkbox
+    Element::RailsFlagCheckbox
     Element::RadioButton
     Element::TextField
     Element::Unclassified
-  ]
+  ], dependent: :destroy
 
   belongs_to :sub_group
+  has_one :group, through: :sub_group
 
   validates :label, presence: true, uniqueness: { scope: :sub_group_id }
+  validate :unique_label_within_group
 
   def self.null
     new(variant: Element::Null.new)
@@ -59,4 +61,17 @@ def displayed?
   def set_command_line_value
     self.command_line_value = generate_command_line_value
   end
+
+  def unique_label_within_group
+    return unless group
+
+    duplicate = group.sub_groups.joins(:elements)
+                    .where.not(elements: { id: id })
+                    .where(elements: { label: label })
+                    .exists?
+
+    if duplicate
+      errors.add(:label, "must be unique within the group")
+    end
+  end
 end

app/models/element.rb

@@ -1,6 +1,6 @@
 # == Schema Information
 #
-# Table name: element_checkboxes
+# Table name: element_rails_flag_checkboxes
 #
 #  id           :integer          not null, primary key
 #  checked      :boolean
@@ -24,21 +24,20 @@
 # Examples:
 #
 # A checkbox for "--no-test"
-# Element::Checkbox.create!(
+# Element::RailsFlagCheckbox.create!(
 #   default: true,           # Starts checked
 #   display_when: "unchecked", # Only outputs when unchecked
 #   # When unchecked, it would output "--no-test"
 # )
 
 # # A checkbox for "--debug"
-# Element::Checkbox.create!(
+# Element::RailsFlagCheckbox.create!(
 #   default: false,          # Starts unchecked
 #   display_when: "checked", # Only outputs when checked
 #   # When checked, it would output "--debug"
 # )
 
-
-class Element::Checkbox < ApplicationRecord
+class Element::RailsFlagCheckbox < ApplicationRecord
   has_one :element, as: :variant
 
   def displayed?

app/models/element/checkbox.rb app/models/element/rails_flag_checkbox.rb

@@ -36,8 +36,6 @@
 class GeneratedApp < ApplicationRecord
   include HasGenerationLifecycle
 
-  attr_accessor :update_recipe
-
   broadcasts_to ->(generated_app) { [ :generated_apps, generated_app.user_id ] }
   broadcasts_to ->(generated_app) { [ :notification_badge, generated_app.user_id ] }
 
@@ -85,12 +83,6 @@ def apply_ingredient!(ingredient, configuration = {})
         configuration: configuration
       )
 
-      # Apply to recipe if update_recipe is true
-      if update_recipe
-        logger.info("Applying recipe change")
-        recipe_change.apply!
-      end
-
       template_path = DataRepository.new(user: user).template_path(ingredient)
 
       require "rails/generators"

app/models/generated_app.rb

@@ -35,7 +35,7 @@ def create_element(sub_group)
       label: ingredient.name,
       description: ingredient.description,
       position: last_position + 1,
-      variant: Element::Checkbox.create!(
+      variant: Element::RailsFlagCheckbox.create!(
         checked: false,
         display_when: "checked"
       )

app/services/ingredient_ui_creator.rb

@@ -23,13 +23,13 @@ def call
       element.destroy
 
       # If this was the last element in the sub_group, delete the sub_group
-      if sub_group.elements.empty?
+      if sub_group.elements.reload.empty?
         sub_group.destroy
-      end
 
-      # If this was the last sub_group in the group, delete the group
-      if group.sub_groups.empty?
-        group.destroy
+        # If this was the last sub_group in the group, delete the group
+        if group.sub_groups.reload.empty?
+          group.destroy
+        end
       end
     end
   end

app/services/ingredient_ui_destroyer.rb

@@ -24,8 +24,8 @@ def view_template
                   action: "change->radio-button-choice#update"
                 }
               )
-            when "Element::Checkbox"
-              render Pages::Groups::SubGroups::Elements::Checkbox::Component.new(
+            when "Element::RailsFlagCheckbox"
+              render Pages::Groups::SubGroups::Elements::RailsFlagCheckbox::Component.new(
                 label: element.label,
                 description: element.description,
                 image_path: element.image_path,
@@ -34,16 +34,10 @@ def view_template
                 command_line_value: element.command_line_value,
                 display_when: element.variant.display_when,
                 data: {
-                  action: "change->check-box#update",
+                  action: "change->rails-flag-checkbox#update",
                   **group_stimulus_attributes
                 }
               )
-            # when "Element::TextField"
-            #   render Pages::Groups::SubGroups::Elements::TextField::Component.new(
-            #     label: element.label,
-            #     description: element.description,
-            #     name: element.label,
-            #   )
             else
               raise "Unknown element variant_type: #{element.variant_type}"
             end

app/views/components/pages/groups/sub_groups/elements/component.rb

@@ -4,7 +4,7 @@ module Pages
   module Groups
     module SubGroups
       module Elements
-        module Checkbox
+        module RailsFlagCheckbox
           class Component < ApplicationComponent
             include Phlex::Rails::Helpers::ImageTag
 
@@ -19,13 +19,13 @@ def initialize(label:, description:, image_path:, name:, command_line_value:, ch
               @display_when = display_when
 
               # Extract the outlet from data if present, defaulting to #rails-flags
-              @outlet = @data.delete("check-box-generated-output-outlet") || "#rails-flags"
+              @outlet = @data.delete("rails-flag-checkbox-generated-output-outlet") || "#rails-flags"
             end
 
             def view_template
-              li(data_controller: "check-box",
+              li(data_controller: "rails-flag-checkbox",
                  data: {
-                   "check-box-generated-output-outlet": @outlet,
+                   "rails-flag-checkbox-generated-output-outlet": @outlet,
                    **@data.except("action")
                  },
                  class: "menu-card-row text-ruby") do

app/views/components/pages/groups/sub_groups/elements/checkbox/component.rb app/views/components/pages/groups/sub_groups/elements/rails_flag_checkbox/component.rb

@@ -0,0 +1,5 @@
+class RenameElementCheckboxesToRailsFlagCheckboxes < ActiveRecord::Migration[7.1]
+  def change
+    rename_table :element_checkboxes, :element_rails_flag_checkboxes
+  end
+end

db/migrate/20250117135204_rename_element_checkboxes_to_rails_flag_checkboxes.rb

@@ -1,37 +1,37 @@
+# frozen_string_literal: true
+
 require "test_helper"
+require "support/phlex_component_test_case"
 
 module Pages
   module Groups
-    class ComponentTest < ActiveSupport::TestCase
-      include Phlex::Testing::ViewHelper
-
-      setup do
-        @databases_group = groups(:databases)
-        @dev_env_group = groups(:dev_env)
+    class ComponentTest < PhlexComponentTestCase
+      test "renders group with stimulus attributes" do
+        group = Group.new(title: "Test Group", behavior_type: "generic_checkbox")
+        group.stubs(:stimulus_attributes).returns({
+          controller: "rails-flag-checkbox",
+          "rails-flag-checkbox-generated-output-outlet": "#rails-flags"
+        })
+        group.stubs(:sub_groups).returns([])
+
+        component = Component.new(group: group)
+        html = component.render_in(view_context)
+
+        assert_includes html, 'data-controller="rails-flag-checkbox"'
+        assert_includes html, 'data-rails-flag-checkbox-generated-output-outlet="#rails-flags"'
       end
 
-      test "renders database choice group with correct stimulus attributes" do
-        component = Component.new(group: @databases_group)
-
-        Pages::Groups::SubGroups::Elements::RadioButton::Component.any_instance
-        .stubs(:image_tag)
-        .returns("image_tag_stub")
+      private
 
-        html = render(component)
-
-        assert_includes html, 'data-controller="radio-button-choice"'
-        assert_includes html, 'data-radio-button-choice-generated-output-outlet="#database-choice"'
-        assert_includes html, 'data-output-prefix="-d"'
+      def view_context
+        controller.view_context
       end
 
-      test "renders generic checkbox group with correct stimulus attributes" do
-        @dev_env_group.update!(behavior_type: "generic_checkbox")
-        component = Component.new(group: @dev_env_group)
-
-        html = render(component)
-
-        assert_includes html, 'data-controller="check-box"'
-        assert_includes html, 'data-check-box-generated-output-outlet="#rails-flags"'
+      def controller
+        @controller ||= ApplicationController.new.tap do |c|
+          c.request = ActionDispatch::TestRequest.create
+          c.response = ActionDispatch::TestResponse.new
+        end
       end
     end
   end