Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Untap effects needs to be rewritten #6011

Open
7 tasks
Hanmac opened this issue Aug 29, 2024 · 0 comments
Open
7 tasks

Can't Untap effects needs to be rewritten #6011

Hanmac opened this issue Aug 29, 2024 · 0 comments
Assignees
Labels

Comments

@Hanmac
Copy link
Contributor

Hanmac commented Aug 29, 2024

Can't Untap effects needs to be rewritten, some could be Statics, some could be SpellAbilityEffects.

Different Cases:

  • Keyword CARDNAME doesn't untap during your untap step. → Static Ability using "CantUntap(Phase)", don't need for Continuous ?
    • Also use it for effects like "doesn't untap during its controller's untap step for as long as EFFECTSOURCE remains on the battlefield."
    • Some Effects target a Player: Creatures target player controls don't untap during that player's next untap step.
    • Some Effects target a Player and be affected cards: Tap all creatures target player controls. Those creatures don't untap during that player's next untap step. the Tricky part is "that player"
    • Drawback of Spells and Activated Effects that say: doesn't untap during your next untap step need to remember You as affected player.
    • For Effects, we also need to be careful who is owning it, or if the Effect should continue for other players
  • Hidden Keyword This card doesn't untap during your next untap step. → CantUntapTurnEffect using N for counting down on the Card. This is only when it means Controller

Better issue for #984

See also:

  • You may choose not to untap CARDNAME during your untap step. should be a static?
  • Also untaps during each <Player> untap step which should be affected by some of the stuff above
    • CARDNAME untaps during each other player's untap step
    • CARDNAME untaps during each opponent's untap step.

Old Branch that is getting recycled: https://github.com/Card-Forge/forge/tree/untapRework

i probably try to do this in smaller sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants