Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseResponse() dependancyValue is invalid - cannot retrieve achievements for some AppIDs #33

Open
DeadStarlin opened this issue Nov 14, 2024 · 3 comments
Assignees

Comments

@DeadStarlin
Copy link
Contributor

Looks like for some AppIDs cannot retrieve achievements like:
24010, 726390, 223470, 1124300
throws error like:
[14:38:46] ERROR ASF > ParseResponse() dependancyValue is invalid!
[14:38:46] ERROR MyBot > GetAchievements() stats is null!

@Rudokhvist
Copy link
Member

Thank you for your report, will try to find why this happens.

@Rudokhvist Rudokhvist self-assigned this Nov 14, 2024
@DeadStarlin
Copy link
Contributor Author

DeadStarlin commented Nov 19, 2024

Looks like simple change - in Achievement Handler there is parsing to uint - line 99 and for achievement "222601_ER20 MRCE Dispolok: High Speed Freight" from AppID 24010 there is max_value as float point - "76.25"
Only question is how this would affect stat_value as it could also be floating point and there is bit shifting

@DeadStarlin
Copy link
Contributor Author

DeadStarlin commented Dec 8, 2024

Added bug in SteamKit as looks like it does not support floats: SteamRE/SteamKit#1478 and looks like xPaw or someone else would need to look into this
About handling if achievement is locked - https://github.com/gibbed/SteamAchievementManager/blob/ac5e1a0c2844d3c37b887ae3dc38d0401c95593e/SAM.Game/Stats/FloatStatInfo.cs#L36

Edit: According to Pavel that how this should be - as this is how Steam Client generates, I tried to look a bit into this but due to lack of time mostly I cannot dig deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants