Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use app_name in strings #2228

Open
TheLastProject opened this issue Dec 13, 2024 · 2 comments
Open

Consistently use app_name in strings #2228

TheLastProject opened this issue Dec 13, 2024 · 2 comments
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: tolerable Low/no impact on users type: bug Something isn't working

Comments

@TheLastProject
Copy link
Member

Several places in strings.xml use the direct text "Catima", it should refer to app_name everywhere so that in languages where the name Catima is transliterated it consistently uses the same everywhere.
@TheLastProject TheLastProject added type: bug Something isn't working severity: tolerable Low/no impact on users common: uncommon Most users are unlikely to come across this or unexpected workflow labels Dec 13, 2024
@TheLastProject TheLastProject self-assigned this Dec 13, 2024
@wesley-94
Copy link

I suggest changing the value of the key "app_name" in the file located at "Android/app/src/main/res/values-ko/strings.xml" from "Catima" to "카티마."
Since I don't know to get editing permissions, I'm leaving this as a comment.

@TheLastProject
Copy link
Member Author

I suggest changing the value of the key "app_name" in the file located at "Android/app/src/main/res/values-ko/strings.xml" from "Catima" to "카티마." Since I don't know to get editing permissions, I'm leaving this as a comment.

Anyone with a Weblate account can edit translations. If you translate the app name, make sure to translate it everywhere, also in Fastlane, for consistency.

@TheLastProject TheLastProject removed their assignment Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: tolerable Low/no impact on users type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheLastProject @wesley-94