Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle HTML in the info dialog with Pkpass codes #2309

Open
theimpulson opened this issue Jan 19, 2025 · 2 comments
Open

Handle HTML in the info dialog with Pkpass codes #2309

theimpulson opened this issue Jan 19, 2025 · 2 comments
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: tolerable Low/no impact on users type: enhancement New feature or request

Comments

@theimpulson
Copy link
Contributor

Summary

Some Pkpass files have HTML in the description shown in the info dialog as raw HTML. It would be nice to show a properly formatted HTML text. This probably can be done using HtmlCompat class.
@theimpulson
Copy link
Contributor Author

I tried it quickly, but the formatting keeps getting messed up.

@TheLastProject
Copy link
Member

TheLastProject commented Jan 23, 2025 •
edited
Loading

I guess we can experiment with this. It'd be important to set some limits on the allowed tags to ensure readability, but yeah.

With regards to formatting issues, my first guess would be that you would want to replace newlines with <br> or <p>, but I haven't really looked into this myself.

@TheLastProject TheLastProject added type: enhancement New feature or request severity: tolerable Low/no impact on users common: uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: tolerable Low/no impact on users type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheLastProject @theimpulson