Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URIs should be decoded before reading from .3dtiles #149

Open
lilleyse opened this issue Aug 19, 2024 · 1 comment
Open

URIs should be decoded before reading from .3dtiles #149

lilleyse opened this issue Aug 19, 2024 · 1 comment

Comments

@lilleyse
Copy link
Contributor

E.g. example%20file.gltf should be decoded to example file.gltf before reading from a .3dtiles database.

CC CesiumGS/3d-tiles#727 (comment)

@javagl
Copy link
Contributor

javagl commented Aug 19, 2024

@lilleyse I think that this will mainly affect the PackageServer (and may therefore be addressed in #86 ). It could raise some subtle questions when we try to add encoding/decoding logic in the layer that accesses the database file. (For 3TZ, there is a "minor" normalization step at

private static normalizePath(path: string) {
, but that's unrelated to encoding/decoding).

When someone does
const value = tilesetSource.getValue("example%20file.gltf");
then this should return the file if and only if it is really stored under that name in the package. (We still have to add some clarifications/constraints to the spec document, though...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants