Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The converter should error out if you use a component selector that doesn't exist #37

Open
2 tasks
baothientran opened this issue Dec 7, 2020 · 0 comments
Open
2 tasks

The converter should error out if you use a component selector that doesn't exist #37

baothientran opened this issue Dec 7, 2020 · 0 comments

Comments

@baothientran
Copy link
Contributor

baothientran commented Dec 7, 2020 •
edited by lilleyse
Loading

E.g. --combine Elevation_1_5 should print an error message

  • The --combine option only checks the dataset to be valid. The component selector check is to see if it is a number and ignore if it doesn't exist. We should error out upfront to let client know if the CS doesn't exist
  • Update the dataset table in the README to indicate which dataset and component selectors are supported
@baothientran baothientran mentioned this issue Dec 7, 2020
Merged
@lilleyse lilleyse changed the title The converter should error out if you use a component selector that doesn't exist. E.g. --combine Elevation_1_5 The converter should error out if you use a component selector that doesn't exist Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baothientran