Skip to content

Commit 55cc9ba

Browse files
committed
tuner becomes modifier, use std::optional for version
1 parent 85103cd commit 55cc9ba

File tree

6 files changed

+22
-16
lines changed

6 files changed

+22
-16
lines changed

Source/CesiumRuntime/Private/Cesium3DTileset.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#include "Camera/CameraTypes.h"
66
#include "Camera/PlayerCameraManager.h"
77
#include "Cesium3DTilesSelection/EllipsoidTilesetLoader.h"
8+
#include "Cesium3DTilesSelection/GltfModifier.h"
89
#include "Cesium3DTilesSelection/Tile.h"
910
#include "Cesium3DTilesSelection/TilesetLoadFailureDetails.h"
1011
#include "Cesium3DTilesSelection/TilesetOptions.h"
@@ -994,7 +995,7 @@ void ACesium3DTileset::LoadTileset() {
994995
? this->BoundingVolumePoolComponent->getPool()
995996
: nullptr,
996997
{},
997-
_gltfTuner
998+
_gltfModifier
998999
};
9991000

10001001
this->_startTime = std::chrono::high_resolution_clock::now();
@@ -2329,7 +2330,7 @@ void ACesium3DTileset::RuntimeSettingsChanged(
23292330
}
23302331
#endif
23312332

2332-
void ACesium3DTileset::SetGltfTuner(
2333-
const std::shared_ptr<Cesium3DTilesSelection::GltfTuner>& tuner) {
2334-
_gltfTuner = tuner;
2333+
void ACesium3DTileset::SetGltfModifier(
2334+
const std::shared_ptr<Cesium3DTilesSelection::GltfModifier>& InModifier) {
2335+
_gltfModifier = InModifier;
23352336
}

Source/CesiumRuntime/Private/CesiumGltfComponent.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3536,11 +3536,11 @@ UCesiumGltfComponent::UCesiumGltfComponent() : USceneComponent() {
35363536
PrimaryComponentTick.bCanEverTick = false;
35373537
}
35383538

3539-
int32 UCesiumGltfComponent::GetTuningVersion() const {
3540-
if (pTile && pTile->getContent().getRenderContent()) {
3541-
return pTile->getContent().getRenderContent()->getModel()._tuningVersion;
3542-
}
3543-
return -1;
3539+
const CesiumGltf::Model* UCesiumGltfComponent::GetGltfModel() const {
3540+
if (pTile)
3541+
if (auto RenderContent = pTile->getContent().getRenderContent())
3542+
return &RenderContent->getModel();
3543+
return nullptr;
35443544
}
35453545

35463546
void UCesiumGltfComponent::UpdateTransformFromCesium(

Source/CesiumRuntime/Private/CesiumGltfComponent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ class UCesiumGltfComponent : public USceneComponent, public ICesiumLoadedTile {
136136
virtual void BeginDestroy() override;
137137

138138
// from ICesiumLoadedTile
139-
int32 GetTuningVersion() const override;
139+
const CesiumGltf::Model* GetGltfModel() const override;
140140

141141
void UpdateFade(float fadePercentage, bool fadingIn);
142142

Source/CesiumRuntime/Public/Cesium3DTileset.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class CesiumViewExtension;
3939
struct FCesiumCamera;
4040

4141
namespace Cesium3DTilesSelection {
42+
class GltfModifier;
4243
class Tileset;
4344
class TilesetView;
4445
class TileOcclusionRendererProxyPool;
@@ -1258,13 +1259,13 @@ class CESIUMRUNTIME_API ACesium3DTileset : public AActor {
12581259
void UpdateTransformFromCesium();
12591260

12601261
/**
1261-
* Sets the glTF model tuner, an optional extension class that can edit
1262+
* Sets the glTF modifier, an optional extension class that can edit
12621263
* each tile's glTF model after it has been loaded, before it can be
12631264
* displayed. Can only be called in the same engine tick after the tileset
12641265
* actor was spawned, or {@link RefreshTileset} was called.
12651266
*/
1266-
void
1267-
SetGltfTuner(const std::shared_ptr<Cesium3DTilesSelection::GltfTuner>& tuner);
1267+
void SetGltfModifier(
1268+
const std::shared_ptr<Cesium3DTilesSelection::GltfModifier>& InModifier);
12681269

12691270
private:
12701271
/**
@@ -1380,7 +1381,7 @@ class CESIUMRUNTIME_API ACesium3DTileset : public AActor {
13801381

13811382
int32 _tilesetsBeingDestroyed;
13821383

1383-
std::shared_ptr<Cesium3DTilesSelection::GltfTuner> _gltfTuner;
1384+
std::shared_ptr<Cesium3DTilesSelection::GltfModifier> _gltfModifier;
13841385

13851386
friend class UnrealPrepareRendererResources;
13861387
friend class UCesiumGltfPointsComponent;

Source/CesiumRuntime/Public/CesiumLoadedTile.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,16 @@
66

77
#include "CesiumLoadedTile.generated.h"
88

9+
namespace CesiumGltf {
10+
struct Model;
11+
}
12+
913
UINTERFACE()
1014
class UCesiumLoadedTile : public UInterface {
1115
GENERATED_BODY()
1216
};
1317
class ICesiumLoadedTile {
1418
GENERATED_BODY()
1519
public:
16-
virtual int32 GetTuningVersion() const = 0;
20+
virtual const CesiumGltf::Model* GetGltfModel() const = 0;
1721
};

0 commit comments

Comments
 (0)