Node does not start after backwards incompatible badger upgrade

[haikoschol]

Describe the bug

Badger is used for a datastore in libp2p. Badger has the concept of a versioned manifest in its database files. When Badger is upgraded to a new version, the manifest version is incremented as well sometimes. In those cases, the node fails to start when trying to load a previously written libp2p datastore.

Expected Behavior

The node starts normally, maybe emitting a warning about an incompatible libp2p datastore.

Current Behavior

The node crashes with the log output given below.

Possible Solution

On startup, detect the error and delete the libp2p datastore. Probably here.

To Reproduce

Steps to reproduce the behaviour:

1. Build a binary from commit 82433af350d2295a7f9e6e4cd1688171e19e1167.
2. Run it and let it sync for a while (to make sure it has peers).
3. Stop the node.
4. Build a binary from commit a46ad52411cb95dad9e706c8c725f00ff940f36d (after this Badger upgrade)
5. Look at the logs.

Log output

Log Output

2024-12-05 18:19:09.205	
  github.com/ChainSafe/gossamer/cmd/gossamer/main.go:33 +0x256


2024-12-05 18:19:09.205	main.main()
2024-12-05 18:19:09.205	goroutine 1 [running]:
2024-12-05 18:19:09.205		Please see https://dgraph.io/docs/badger/faq/#i-see-manifest-has-unsupported-version-x-we-support-y-error on how to fix this.
2024-12-05 18:19:09.205	panic: failed to create node services: failed to create network service: failed to create host: failed to create libp2p datastore: unsupported badger version, use github.com/ipfs/badgerds-upgrade to upgrade: manifest has unsupported version: 7 (we support 8).

Specification

• go version: 1.23.2
• gossamer version: development
• gossamer commit tag: NA
• gossamer commit hash: 82433af350d2295a7f9e6e4cd1688171e19e1167 & a46ad52411cb95dad9e706c8c725f00ff940f36d
• operating system: any
• additional links: NA

[haikoschol]

closed in #4382