You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Above is my system theme ("Materia Dark") and bellow is the default Fusion theme.
The fusion theme looks old and dated. It makes the whole application not integrated like the other qt applications on my system. Fusion looks dated and the solution that is used from stackoverflow is almost 8 years old.
I commented out these two lines and got no errors. QApplication::setStyle(QStyleFactory::create("Fusion")); installCustomPalette();
Of course you are doing this because you want a dark theme on windows, but please make a check if the system is linux and have it use the system theme.
The text was updated successfully, but these errors were encountered:
The settings ui is designed for darkmode only. So changing this to system theme requires adjusting the theme for light mode. Maybe there is a non-hacky way to check if the OS theme is dark?
Here is the application with a light theme ("Materia")
It's not unusable, but definitely needs work if implemented.
The reason the light-themes does not work is that ui color should have not been defined outside the installCustomPalette colors. The text that uses the dark.setColor(QPalette::Text, Qt::white); switches color to black when a light theme is used. Text that used a custom color stayed white when they should have not.
So i don't think there needs to be a check if a light mode is used.
Now this is a lot of effort to basically rewrite a lot of the ui. And only a small set of users that compile the program for themselves (there is no linux binary), gets any benefit.
I do recommend to start using or changing the QPalette colors instead of defining custom colors, will make it easier to move to a newer version of qt or update form the fusion theme.
Above is my system theme ("Materia Dark") and bellow is the default Fusion theme.
The fusion theme looks old and dated. It makes the whole application not integrated like the other qt applications on my system. Fusion looks dated and the solution that is used from stackoverflow is almost 8 years old.
I commented out these two lines and got no errors.
QApplication::setStyle(QStyleFactory::create("Fusion")); installCustomPalette();
Of course you are doing this because you want a dark theme on windows, but please make a check if the system is linux and have it use the system theme.
The text was updated successfully, but these errors were encountered: