Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added notes to usercards #3745

Closed
wants to merge 5 commits into from
Closed

Added notes to usercards #3745

wants to merge 5 commits into from

Conversation

anqueue
Copy link
Contributor

@anqueue anqueue commented May 16, 2022 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Allows users to set notes for other people. The note is stored alongside the user's ID so a username change wont affect them. All clientside and doesn't have to do with mod comments. Works kind of like the discord notes. would close #2413

Functionality is all there, just need to make the UI look better

Example:

qtcreator_1652740346_plN.mp4

@kornes
Copy link
Contributor

kornes commented May 17, 2022

early suggestions:

  • current UI in demo is imo way too prominent for this feature. What about adding "Note:" row above Views, limited to single row of text and expandable to full length at click. Preferably edited inline after pressing some small pen icon ✏️ button.
  • store user notes in own file

xHeaveny
xHeaveny reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@xHeaveny xHeaveny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make the place for the notes a lot smaller because now its j8ust too big in my opinion

@anqueue
Copy link
Contributor Author

anqueue commented May 23, 2022

I would make the place for the notes a lot smaller because now its j8ust too big in my opinion

Wanted to get something down first. Didn't know how the UI should be when making this PR. I'll work on kornes' suggestions later today/tomorrow

@Felanbird
Copy link
Collaborator

I'm wondering if a better approach is displaying the note, and using a small edit button to bring up a prompt to set the note. It seems very correct to just have a seperate window for setting the note.

similar to the PR adding a reply window
c2_3745

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 23, 2022 •
edited
Loading

using a small edit button to bring up a prompt to set the note

I'd dislike having a popup window spawning a popup window. I feel like that might get confusing. pajaDent

But a green or blue paint on the bikeshed doesn't really matter when there is no bikeshed built yet.

@pajlada
Copy link
Member

pajlada commented Jun 7, 2022

  • Use a separate file for this rather than saving it in settings.json
  • Improve UI (see Discord for inspiration)

@Felanbird
Copy link
Collaborator

  • Make sure newly created notes.json have backups automatically generated

@anqueue
Copy link
Contributor Author

anqueue commented Aug 12, 2022

Lost interest in this, if anyone wants to pick this up go ahead.

@anqueue anqueue closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xHeaveny xHeaveny xHeaveny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user 'notes' to usercards
6 participants
@anqueue @kornes @Felanbird @Mm2PL @pajlada @xHeaveny