Reduce Compilation Warnings

[Nerixyz]

When compiling Chatterino, there are a few warnings. These depend on the compiler and configuration used, so I'd like to collect them all here and have some kind of tracking issue.

If you're fixing a warning, please do one category (e.g. unused variables) or subcategory or file at a time (like #4818).

I'll start with Qt 6 on Windows with MSVC. Note that C4100, C4458, and C4267 are explicitly disabled in CMake.

Update: MSVC doesn't report any warnings now.

---

clang-cl reports the following warnings:

missing-field-initializers

This is really noisy, especially for Emote, but easy to fix.

• Args.cpp: missing field 'filters_' initializer
• WindowDescriptors.cpp: missing field 'filters_' initializer
• WindowDescriptors.cpp: missing field 'customTitle_' initializer
• WindowDescriptors.cpp: missing field 'filters_' initializer
• WindowDescriptors.cpp: missing field 'customTitle_' initializer
• SharedMessageBuilder.cpp: missing field 'twitchUserID' initializer
• ChatterinoBadges.cpp: missing field 'id' initializer
• BttvEmotes.cpp: missing field 'id' initializer
• BttvEmotes.cpp: missing field 'author' initializer
• FfzBadges.cpp: missing field 'id' initializer
• Emojis.cpp: missing field 'id' initializer
• FfzEmotes.cpp: missing field 'id' initializer
• SeventvBadges.cpp: missing field 'author' initializer
• TwitchBadges.cpp: missing field 'id' initializer
• TwitchBadges.cpp: missing field 'id' initializer
• TwitchEmotes.cpp: missing field 'homePage' initializer
• TwitchMessageBuilder.cpp: missing field 'captureNumber' initializer
• TwitchMessageBuilder.cpp: missing field 'id' initializer
• TwitchChannel.cpp: missing field 'id' initializer
• TwitchChannel.cpp: missing field 'id' initializer
• TwitchChannel.cpp: missing field 'id' initializer
• BaseWindow.cpp: missing field 'cxRightWidth' initializer

unused-function

• RunGui.cpp: unused function 'createRunningFile'
• RunGui.cpp: unused function 'removeRunningFile'
• RunGui.cpp: unused function 'handleSignal'
• BttvEmotes.cpp: unused function 'getEmoteLink'
• SeventvEmotes.cpp: unused function 'isZeroWidthRecommended'

unused-variable

• Impl.cpp: unused variable 'LOG'

unused-but-set-variable

• MessageBuilder.cpp: variable 'bg' set but not used

unused-lambda-capture

• WindowManager.cpp: lambda capture 'this' is not used

switch

This warning is off on non-MSVC builds. I'd argue it should be turned on.

• Account.cpp: enumeration value 'Irc' not handled in switch
• AccountController.cpp: enumeration value 'Irc' not handled in switch
• WindowManager.cpp: enumeration value 'EmptyRoot' not handled in switch
• WindowManager.cpp: enumeration values 'None', 'Direct', and 'TwitchEnd' not handled in switch
• WindowManager.cpp: enumeration value 'None' not handled in switch
• NotificationPopup.cpp: enumeration values 'TopLeft', 'TopRight', and 'BottomLeft' not handled in switch
• HighlightingPage.cpp: enumeration value 'Blacklist' not handled in switch
• SplitContainer.cpp: enumeration value 'EmptyRoot' not handled in switch
• SplitHeader.cpp: 27 enumeration values not handled in switch: 'MouseButtonMask', 'NoButton', 'BackButton'...

unused-private-field

• AttachedWindow.hpp: private field 'yOffset_' is not used
• AttachedWindow.hpp: private field 'currentYOffset_' is not used
• FlowLayout.hpp: private field 'lineSpacing_' is not used
• AccountsPage.hpp: private field 'addButton_' is not used
• AccountsPage.hpp: private field 'removeButton_' is not used
• AccountsPage.hpp: private field 'accountSwitchWidget_' is not used

tautological-constant-out-of-range-compare

• miniaudio.h: result of comparison of constant 2147483647 with expression of type 'ma_seek_origin' is always false

[Mm2PL]

We should not even care about "Shadowing class variables (C4458)". We always use this-> anyway.

[Nerixyz]

We should not even care about "Shadowing class variables (C4458)". We always use this-> anyway.

Yes, we don't care about that. It was disabled in #5137. I updated the list.