Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most #defines #4896

Open
Nerixyz opened this issue Oct 13, 2023 · 0 comments
Open

Remove most #defines #4896

Nerixyz opened this issue Oct 13, 2023 · 0 comments
Labels
Refactor

Comments

@Nerixyz
Copy link
Contributor

Nerixyz commented Oct 13, 2023 •
edited
Loading

There are a few #defines in the code right now that can be replaced by (constexpr) functions/constants.

For strings, QString literals (const QString FOO = u"foo"_s) can be used (in some cases, QStringView might be useful - its constructor is constexpr).

As a sidenote, maybe QStringView operator""_sv should be added.
@Nerixyz Nerixyz added the issue-report An issue reported by a user. label Oct 13, 2023
@pajlada pajlada added Refactor and removed issue-report An issue reported by a user. labels Oct 13, 2023
@ScrubN ScrubN mentioned this issue Dec 1, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pajlada @Nerixyz