Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply button shows on received whispers #5778

Open
4 tasks done
Nerixyz opened this issue Dec 27, 2024 · 0 comments
Open
4 tasks done

Reply button shows on received whispers #5778

Nerixyz opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user good first issue

Comments

@Nerixyz
Copy link
Contributor

Nerixyz commented Dec 27, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

When the "Show message reply button" setting is enabled, a reply button is shown on received whispers. It shouldn't show on received whispers as you can't reply to them.

This should be fairly simple - the button is added here:

if (thread)
{
auto &img = getResources().buttons.replyThreadDark;
builder
.emplace<CircularImageElement>(Image::fromResourcePixmap(img, 0.15),
2, Qt::gray,
MessageElementFlag::ReplyButton)
->setLink({Link::ViewThread, thread->rootId()});
}
else
{
auto &img = getResources().buttons.replyDark;
builder
.emplace<CircularImageElement>(Image::fromResourcePixmap(img, 0.15),
2, Qt::gray,
MessageElementFlag::ReplyButton)
->setLink({Link::ReplyToMessage, builder->id});
}

Screenshots

(the highlighted message shouldn't have the button)

OS and Chatterino Version

Chatterino Nightly 7.5.1 (commit 64665d5) built on 2024-12-08 with Qt 6.8.1, MSVC 194134120, Crashpad - Running on Windows 10 Version 22H2, kernel: 10.0.19045

@Nerixyz Nerixyz added the issue-report An issue reported by a user. label Dec 27, 2024
@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user good first issue and removed issue-report An issue reported by a user. labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user good first issue
Projects
None yet
Development

No branches or pull requests

2 participants