From 31fc7580064f74bb4491005e6a0dfe773643c790 Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sun, 15 Oct 2023 15:33:09 +0200 Subject: [PATCH 1/2] FilterParser: Make explainIllType anonymous/static --- src/controllers/filters/lang/FilterParser.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/controllers/filters/lang/FilterParser.cpp b/src/controllers/filters/lang/FilterParser.cpp index 00e3bf77618..dddbd164a5f 100644 --- a/src/controllers/filters/lang/FilterParser.cpp +++ b/src/controllers/filters/lang/FilterParser.cpp @@ -9,7 +9,9 @@ #include "controllers/filters/lang/Filter.hpp" #include "controllers/filters/lang/Types.hpp" -namespace chatterino::filters { +namespace { + +using namespace chatterino::filters; QString explainIllType(const IllTyped &ill) { @@ -18,6 +20,10 @@ QString explainIllType(const IllTyped &ill) .arg(ill.expr->filterString()); } +} // namespace + +namespace chatterino::filters { + FilterParser::FilterParser(const QString &text) : text_(text) , tokenizer_(Tokenizer(text)) From eecb4efcfd0384c8224cb953404d6b538b8c088c Mon Sep 17 00:00:00 2001 From: Rasmus Karlsson Date: Sun, 15 Oct 2023 15:33:29 +0200 Subject: [PATCH 2/2] FilterParser: Comment constructor --- src/controllers/filters/lang/FilterParser.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/controllers/filters/lang/FilterParser.hpp b/src/controllers/filters/lang/FilterParser.hpp index 3f0344627fd..1fa8fa596fa 100644 --- a/src/controllers/filters/lang/FilterParser.hpp +++ b/src/controllers/filters/lang/FilterParser.hpp @@ -9,6 +9,9 @@ namespace chatterino::filters { class FilterParser { public: + /** + * Take input text & attempt to parse it into a filter + **/ FilterParser(const QString &text); bool valid() const;