Final lint changes

Author: cx-Romeu-Alves

Diff for: cmd/root.go

@@ -59,7 +59,7 @@ Produces:
 
 NOTE the minimum supported SAST version is 9.3. SAST installations below this version should be upgraded in order to run this export tool. 
 `,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 
 		// Validate simIDVersion if provided
 		if simIDVersion < 0 || simIDVersion > 2 {

Diff for: cmd/version.go

@@ -15,7 +15,7 @@ var versionCmd = &cobra.Command{
 	Use:   "version",
 	Short: fmt.Sprintf("Print the version number of %s", productName),
 	Long:  fmt.Sprintf(`All software has versions. This is %s's`, productName),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		fmt.Printf("%s %s+%s\n", productName, productVersion, productBuild)
 	},
 }

Diff for: internal/integration/rest/utils.go

@@ -25,13 +25,13 @@ func GetFilterForProjects(fromDate, teamName, projectIDs string) string {
 		return getProjectFilterForEmptyDate(projectIDs, teamName)
 	}
 	if teamName == "" {
-		return fmt.Sprintf("CreatedDate gt %s and %s", fromDate, getProjectIdsFilter(projectIDs))
+		return fmt.Sprintf("CreatedDate gt %s and %s", fromDate, getProjectIDsFilter(projectIDs))
 	}
 	if projectIDs == "" {
 		return fmt.Sprintf("CreatedDate gt %s and %s", fromDate, getTeamFilter(teamName))
 	}
 	return fmt.Sprintf("CreatedDate gt %s and %s and %s", fromDate, getTeamFilter(teamName),
-		getProjectIdsFilter(projectIDs))
+		getProjectIDsFilter(projectIDs))
 }
 
 // GetFilterForProjectsWithLastScan get filter string for projects list with last scan
@@ -43,53 +43,53 @@ func GetFilterForProjectsWithLastScan(fromDate, teamName, projectIDs string) str
 		return getProjectFilterForEmptyDate(projectIDs, teamName)
 	}
 	if teamName == "" {
-		return fmt.Sprintf("LastScan/ScanCompletedOn gt %s and %s", fromDate, getProjectIdsFilter(projectIDs))
+		return fmt.Sprintf("LastScan/ScanCompletedOn gt %s and %s", fromDate, getProjectIDsFilter(projectIDs))
 	}
 	if projectIDs == "" {
 		return fmt.Sprintf("LastScan/ScanCompletedOn gt %s and %s", fromDate, getTeamFilter(teamName))
 	}
 	return fmt.Sprintf("LastScan/ScanCompletedOn gt %s and %s and %s", fromDate, getTeamFilter(teamName),
-		getProjectIdsFilter(projectIDs))
+		getProjectIDsFilter(projectIDs))
 }
 
 // getProjectFilterForEmptyDate get project filter when date empty
 func getProjectFilterForEmptyDate(projectIDs, teamName string) string {
 	if teamName == "" {
-		return getProjectIdsFilter(projectIDs)
+		return getProjectIDsFilter(projectIDs)
 	}
-	return fmt.Sprintf("%s and %s", getProjectIdsFilter(projectIDs), getTeamFilter(teamName))
+	return fmt.Sprintf("%s and %s", getProjectIDsFilter(projectIDs), getTeamFilter(teamName))
 }
 
 // getTeamFilter get filter string for team
 func getTeamFilter(teamName string) string {
 	return fmt.Sprintf("OwningTeam/FullName eq '%s'", teamName)
 }
 
-// getProjectIdsFilter get filter string for project-id option
-func getProjectIdsFilter(projectIds string) string {
-	if matched, _ := regexp.MatchString(`^\d+$`, projectIds); matched {
-		return fmt.Sprintf("Id eq %s", projectIds)
+// getProjectIDsFilter get filter string for project-id option
+func getProjectIDsFilter(projectIDs string) string {
+	if matched, _ := regexp.MatchString(`^\d+$`, projectIDs); matched {
+		return fmt.Sprintf("Id eq %s", projectIDs)
 	}
-	if matched, _ := regexp.MatchString(`^\d+(,\s?\d+)+$`, projectIds); matched {
-		return fmt.Sprintf("Id in (%s)", projectIds)
+	if matched, _ := regexp.MatchString(`^\d+(,\s?\d+)+$`, projectIDs); matched {
+		return fmt.Sprintf("Id in (%s)", projectIDs)
 	}
-	if matched, _ := regexp.MatchString(`^\d+\s?-\s?\d+$`, projectIds); matched {
-		ids := strings.Split(projectIds, "-")
-		min, max := getMinMax(ids)
-		return fmt.Sprintf("Id ge %d and Id le %d", min, max)
+	if matched, _ := regexp.MatchString(`^\d+\s?-\s?\d+$`, projectIDs); matched {
+		ids := strings.Split(projectIDs, "-")
+		minValue, maxValue := getMinMax(ids)
+		return fmt.Sprintf("Id ge %d and Id le %d", minValue, maxValue)
 	}
 
 	log.Warn().Msg("--project-id has wrong param. It should be like --project-id 1 or 1,3,8 or 1-3")
 	return "Id gt 0"
 }
 
 // getMinMax get min and max values
-func getMinMax(ids []string) (min, max int) {
-	min, _ = strconv.Atoi(strings.Trim(ids[0], " "))
-	max, _ = strconv.Atoi(strings.Trim(ids[1], " "))
-	if min > max {
-		min, max = max, min
+func getMinMax(ids []string) (minValue, maxValue int) {
+	minValue, _ = strconv.Atoi(strings.Trim(ids[0], " "))
+	maxValue, _ = strconv.Atoi(strings.Trim(ids[1], " "))
+	if minValue > maxValue {
+		minValue, maxValue = maxValue, minValue
 	}
 
-	return min, max
+	return minValue, maxValue
 }

Diff for: internal/process.go

@@ -830,14 +830,14 @@ func getRetryHTTPClient() *retryablehttp.Client {
 		RetryMax:     httpRetryMax,
 		CheckRetry:   retryablehttp.DefaultRetryPolicy,
 		Backoff:      retryablehttp.DefaultBackoff,
-		RequestLogHook: func(logger retryablehttp.Logger, request *http.Request, i int) {
+		RequestLogHook: func(_ retryablehttp.Logger, request *http.Request, i int) {
 			log.Debug().
 				Str("method", request.Method).
 				Str("url", request.URL.String()).
 				Int("attempt", i+1).
 				Msg("request")
 		},
-		ResponseLogHook: func(logger retryablehttp.Logger, response *http.Response) {
+		ResponseLogHook: func(_ retryablehttp.Logger, response *http.Response) {
 			log.Debug().
 				Str("method", response.Request.Method).
 				Str("url", response.Request.URL.String()).