Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in hal_fsmc.h #227

Open
sabdulqadir opened this issue Nov 24, 2020 · 1 comment
Open

Bug in hal_fsmc.h #227

sabdulqadir opened this issue Nov 24, 2020 · 1 comment
Assignees

Comments

@sabdulqadir
Copy link
Contributor

sabdulqadir commented Nov 24, 2020

First of all,
Thanks to @barthess, @fpoussin, and everyone else who contributed to providing NAND flash driver.
I recently tried moving from 18.2.0 to 20.3.2 and had following issues:

  1. For ChibiOS-Contrib/os/hal/include/hal_fsmc.h:37 => needs to include stm32f7x targets

  2. Also line324 on the same file has a typo "STM32_NAND_USE_NAND1" instead of "STM32_NAND_USE_NAND2"

  3. Should dmaStreamAlloc(nandp->dma, be=> nandp->dma = dmaStreamAlloc(STM32_NAND_DMA_STREAM,

If you guys deem it suitable, I can make these changes and do a pull request.

Thanks,
AQ

ChibiOS version: 20.3.2
Compiler: arm-none-eabi-gcc (7-2018-q2-update)(7.3.1)
Platform and board:STM32F723ZE (custom board)
Nature of the problem: Cannot compile
Failure mode: n/a

@fpoussin fpoussin self-assigned this Nov 25, 2020
@fpoussin
Copy link
Member

fpoussin commented Dec 6, 2020

Hi @sabdulqadir, feel free to send in a pull request, that would help us.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants