Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion to nand flash driver #251

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Expansion to nand flash driver #251

merged 1 commit into from
Feb 14, 2021

Conversation

sabdulqadir
Copy link
Contributor

This expansion helps support higher density devices which have multiple
dies, logical units and planes on top of the standard block and page
structures of standard nand flash ICs.

  • Included stm32f723xx targets
  • Bug fix (STM32_NAND_USE_NAND1)
  • changed map_cmd and map_addr to 8 bits in struct NANDDriver
  • Bug fix (dmaStreamAlloc returns dma_stream_t)
  • DSB assembly instruction added for fixing issues with M7 processor
  • added nand_lld_read_id() function

This expansion helps support higher density devices which have multiple
dies, logical units and planes on top of the standard block and page
structures of standard nand flash ICs.

- Included stm32f723xx targets
- Bug fix (STM32_NAND_USE_NAND1)
- changed map_cmd and map_addr to 8 bits in struct NANDDriver
- Bug fix (dmaStreamAlloc returns dma_stream_t)
- DSB assembly instruction added for fixing issues with M7 processor
- added nand_lld_read_id() function
@sabdulqadir
Copy link
Contributor Author

Hi,
This is regarding the bug I reported earlier (Bug in hal_fsmc.h #227).
I also included the changes I did to expand the driver to make it work with devices with higher densities (die, logical units and planes). For simpler devices, these can be defined as 1 for the sake of expansion.

I see some build tests have failed and ill work my way through them.
Let me know what you guys think about the changes.

Thanks,
AQ

@fpoussin
Copy link
Member

fpoussin commented Jan 4, 2021

@fpoussin
Copy link
Member

Hi, did you have time to look at the build error?
Thanks

@sabdulqadir
Copy link
Contributor Author

sabdulqadir commented Feb 13, 2021

Hi, did you have time to look at the build error?
Thanks

Hi Fabian,
Not just yet, I am busy with some deliverables.
Ill hopefully get it done by end of this month, unless you tell me it's more urgent.

Thanks,
AQ

@fpoussin
Copy link
Member

Hi, did you have time to look at the build error?
Thanks

Hi Fabian,
Not just yet, I am busy with some deliverables.
Ill hopefully get it done by end of this month, unless you tell me it's more urgent.

Thanks,
AQ

it's not urgent, there are just some examples in testhal to update since you changed the nand function declarations.
I'll merge it and fix the examples. Thanks!

@fpoussin fpoussin merged commit c0b5cfa into ChibiOS:chibios-20.3.x Feb 14, 2021
@sabdulqadir
Copy link
Contributor Author

Thanks Fabien for the help.
Appreciate it.
AQ

@sabdulqadir sabdulqadir deleted the feat/expanding_hal_nand_c branch February 21, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants