Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextKitPlus and BaseTextView can’t be used together #1

Open
wjk opened this issue Nov 10, 2023 · 4 comments
Open

TextKitPlus and BaseTextView can’t be used together #1

wjk opened this issue Nov 10, 2023 · 4 comments

Comments

@wjk
Copy link

wjk commented Nov 10, 2023

What the title says, really. TextViewPlus makes all kinds of calls to the layoutManager, which will assert in Debug, and return a nil value in Release, when used on a BaseTextView. This will cause the control to break. I don’t believe that this is intentional. Unless there’s something here I’m not seeing, of course. 😉

@mattmassicotte
Copy link
Contributor

Most of this library was built before TextKit 2 existed. BaseTextView is really focused on TextKit 2. That's one of the reasons it is so strict about preventing a TK2 -> TK 1 downgrade. It's so easy to do by accident!

I'm not 100% sure all of the original concepts make sense. They might! But I'm still actively investigating TK2. If you have thoughts/opinions I'd love to hear them!

@wjk
Copy link
Author

wjk commented Nov 10, 2023

@mattmassicotte Fair enough. I just assumed it would be this way based on the wording of the documentation. That being said, I think TextKit 2 support would be great, as it would let me standardize on TextKit 2 for all of the text views in my app. Just a thought!

@mattmassicotte
Copy link
Contributor

Absolutely not a bother! The opposite in fact 😃 I'd be happy to answer any other questions you have about any of these repos! Please don't be shy.

I should probably update that. But, these things are really fresh and under active development. And I tend to play pretty fast and loose in that situation, for better or worse.

@mattmassicotte
Copy link
Contributor

I have now made a tiny bit of progress on this, and do intend bridging some of these gaps. How many its clear though, because some concepts do not make sense in the TextKit 2 world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants