Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browsers): vivaldi setup #718

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

leventbesli
Copy link
Contributor

Type of Change

  • New feature
  • [x ] Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Vivaldi setup section was containing Lynx install script. I replaced it with Vivaldi.

Testing

Tested inside Fedora 40 and Debian 12 Distrobox environments. Installed successfully in both of them.

Additional Information

First PR. Be gentle.

Checklist

  • [ x] My code adheres to the coding and style guidelines of the project.
  • [ x] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [x ] My changes generate no errors/warnings/merge conflicts.

Sorry, something went wrong.

Lynx install script replaced with Vivaldi.
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...

Copy link
Contributor

@jeevithakannan2 jeevithakannan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Need to add pacman and zypper in the installation
  • Fix formatting
  • Drop the changes to Cargo.lock ( Not that important )

- zypper and pacman added.
- format fixes.
@leventbesli
Copy link
Contributor Author

leventbesli commented Oct 2, 2024

Hi guys. pacman and zypper added to script. Tested on OpenSuse and Arch. I would appreciate your help about dropping cargo.lock change .

This reverts commit 0b0f173.
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copy paste the the cargo.lock from the repo and push it. The cargo lock is fixed in the main branch.

@leventbesli
Copy link
Contributor Author

Just copy paste the the cargo.lock from the repo and push it. The cargo lock is fixed in the main branch.

Thanks. I think there is no problem now. I see version = “24.9.28” in my fork and in the master branch.

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the cargo lock changes or Chris will most likely decline this PR

@jeevithakannan2
Copy link
Contributor

Don't do git rm cargo.lock

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Oct 4, 2024

there are still cargo lock changes...

@jeevithakannan2
Copy link
Contributor

Merge with upstream/main. It will fix the issue

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit these changes

leventbesli and others added 2 commits October 4, 2024 13:28
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
@leventbesli
Copy link
Contributor Author

thanks to @nnyyxxxx and @jeevithakannan2 for all the help.

@adamperkowski adamperkowski changed the title Fixed Vivaldi Setup fix(browsers): vivaldi setup Oct 25, 2024
@adamperkowski adamperkowski added the bug Something isn't working label Oct 25, 2024
@ChrisTitusTech ChrisTitusTech merged commit 2837f92 into ChrisTitusTech:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants