-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browsers): vivaldi setup #718
Conversation
Lynx install script replaced with Vivaldi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Need to add pacman and zypper in the installation
- Fix formatting
- Drop the changes to Cargo.lock ( Not that important )
- zypper and pacman added. - format fixes.
Hi guys. pacman and zypper added to script. Tested on OpenSuse and Arch. I would appreciate your help about dropping cargo.lock change . |
This reverts commit 0b0f173.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just copy paste the the cargo.lock from the repo and push it. The cargo lock is fixed in the main branch.
Thanks. I think there is no problem now. I see version = “24.9.28” in my fork and in the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the cargo lock changes or Chris will most likely decline this PR
d723dd0
to
92a0d7c
Compare
Don't do git rm cargo.lock |
there are still cargo lock changes... |
Merge with upstream/main. It will fix the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit these changes
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
Co-authored-by: Nyx <144965845+nnyyxxxx@users.noreply.github.com>
thanks to @nnyyxxxx and @jeevithakannan2 for all the help. |
Type of Change
Description
Vivaldi setup section was containing Lynx install script. I replaced it with Vivaldi.
Testing
Tested inside Fedora 40 and Debian 12 Distrobox environments. Installed successfully in both of them.
Additional Information
First PR. Be gentle.
Checklist