panic when scrolling

[jeevithakannan2]

Describe the bug

• When running a command the scrolling causes a panic.
• Turns out it is caused by a bug in vt100 Fix scrollback offset bugs doy/vt100-rust#11

To Reproduce

Steps to reproduce the behavior:

1. Run any command that outputs a very long message.
2. Press pageup 3 to 4 times.
3. See error.

Expected behavior

• No panic and scroll up

Screenshots

Additional context

Workarounds

• Limit the scroll offset up to the maximum number of rows of terminal

  linutil/tui/src/running_command.rs

  Line 256 in d3a801d

  let mut parser = vt100::Parser::new(size.height, size.width, 200);

• Remove the scroll functionality for now.

Solution

• Fork the vt100 and make our own crate just like the how other big projects are doing ( Big changes needed in linutil )
• Switching to a different parser ( Not ideal ).

Checklist

• I checked for duplicate issues.
• I checked already existing discussions.
• This issue is not included in the roadmap.
• This issue is present on both stable and development branches.

[nnyyxxxx]

@jeevithakannan2 its not a linutil issue i would just leave it how it is until it gets fixed in vt100

[nnyyxxxx]

actually, it looks like vt100 hasnt been updated in a year, maybe we should fix this 😆 i wouldnt be saying this if it was being actively updated though

[jeevithakannan2]

Yeah it is not active that's why I created a issue here to get feedback. I could fork the vt100 and apply the fixes. Making our own version of vt100

[nnyyxxxx]

Yeah it is not active that's why I created a issue here to get feedback. I could fork the vt100 and apply the fixes. Making our own version of vt100

we should let Chris decide

[nnyyxxxx]

we should add keybindings for arrow keys as well

[nnyyxxxx]

once this gets fixed

[jeevithakannan2]

Adding key bindings for arrowkeys is bad as we use up and down keys in scripts

[nnyyxxxx]

Adding key bindings for arrowkeys is bad as we use up and down keys in scripts

j and k dont work when running scripts neither do arrow keys, + arrow keys is a good addition to avoid conflicts with j and k

[adamperkowski]

@ChrisTitusTech i summon you

[ChrisTitusTech]

Well shit. I guess for now we can remove scroll and if have the means to fix or fork we can do that in the future.

[adamperkowski]

if we were to remove scroll, i'd not remove code but turn scroll into an optional feature

[adamperkowski]

i'll research this issue in some time. maybe there's a workaround

[cartercanedy]

mproc-vt100 looks like a recently updated fork, idk how much they've refactored the api

[jeevithakannan2]

Will keep this issue open until the scroll feature is fixed. Until then we should remove it. Just 6 lines of code is not a big deal. The biggest issue here is if a command is running and a panic happens the child is not killed leading to potential issues.

[jeevithakannan2]

mproc-vt100 looks like a recently updated fork, idk how much they've refactored the api

I looked at a bunch of forks the tui-term does not run with forks. Need to sort this out