Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After install of Linutil get update error #738

Closed
2 of 4 tasks
angryguy-win opened this issue Oct 2, 2024 · 10 comments
Closed
2 of 4 tasks

After install of Linutil get update error #738

angryguy-win opened this issue Oct 2, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@angryguy-win
Copy link

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. clicked Linutil Installer
  2. quit Linutil
  3. run linutil
  4. clicked update linutil
  5. See error

Expected behavior

Used the Linutil to install its self pick the stable-bin
If i click on the Linutil update.
I get this error ??

Screenshots

image

Additional context

Add any other context about the problem here.

Checklist

  • I checked for duplicate issues.
  • I checked already existing discussions.
  • This issue is not included in the roadmap.
  • This issue is present on both stable and development branches.
@angryguy-win angryguy-win added the bug Something isn't working label Oct 2, 2024
@angryguy-win
Copy link
Author

I even uninstalled it and tried again still the same

@adamperkowski
Copy link
Collaborator

adamperkowski commented Oct 2, 2024

Well, this is not an error (although technically it is).
I thought the message would be pretty self explanatory. You said:

Used the Linutil to install its self pick the stable-bin

I understand that by stable-bin you mean linutil-bin.
This is an AUR package. It clearly says This script only updates the binary installed through cargo..

/close not planned

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
@angryguy-win
Copy link
Author

angryguy-win commented Oct 2, 2024

but that makes NO sense what so ever there an option to linutil installer and get replace by linuit update would you not assume this it suppose to update the installer ??..
there is no way this is working as intended ?... and if it is this is just dumb design ... the logic is flawed..
it give 3 option there nothing there about being install through cargo ..?,

@angryguy-win
Copy link
Author

image

@angryguy-win
Copy link
Author

image

@adamperkowski
Copy link
Collaborator

and if it is this is just dumb design ... the logic is flawed..
it give 3 option there nothing there about being install through cargo ..?
there is no way this is working as intended ?... and if it is this is just dumb design ... the logic is flawed..

This is working as intended and is not flawed. We're here to work on this project, not insult each others' work so please don't.
If you'd read the documentation (or have a basic understanding of our (and crate) packaging), you'd know that the crates.io package is only used as a fallback. It's not recommended to install standalone binaries through cargo, because updates just don't work.

Cargo is not a package manager.

That's why you don't see an option to install the crates.io package.

@angryguy-win
Copy link
Author

It not an insult I'm trying to explain to you some thing ?... but your just not listening... if installer and update are not mutually exclusive then one should not replace the other this is confusing to user....
if they are two different thing then they should be two different things...

@adamperkowski
Copy link
Collaborator

I do understand your point and I know it may be confusing. Keeping both was my original idea but I reached out to the community for opinions and I think (don't really remember) that we decided to add a general preconditions if linutil exists in user's system. Theoretically, checking if the crate is installed and only then showing Linutil Updater would be a good idea but technically that would require changing a little too much in my opinion - adding an explicit cargo package check for linutil as a core functionality.
We could check for linutil in $HOME/.cargo/bin (file checking is already implemented) but although cargo is in $HOME/.cargo by default, it does not have to be the case for all users.

But yes I agree that we should probably change something here. Add a note about crates.io for example.

@angryguy-win
Copy link
Author

angryguy-win commented Oct 2, 2024

Thank you that was it I wasn't trying insult you sorry if it seam that way, but a new user will never understand what that errors mean it will be very confusing to them... if they don't understand the difference they would assume there install in broken and that they cant update.. even for a some gracefuls handling that just does a yay -Syu linutil-bin or which method of choice, or at the least an error that newbies friendly like update this way this command ect ... or explain the crates.io

@adamperkowski
Copy link
Collaborator

No problem. I'll keep this issue in mind and do a bigger refactor of the scripts when I have time to do so. We want to focus more on fixing current bugs for now so UX gimmicks like this aren't our top priority ATM.
We might want to implement custom shell-command based preconditions for entries but a change like this, that could affect performance, will need a bigger discussion.
Anyway, thank you for reporting this, I will definitely be thinking of good solution. Other scripts might benefit from this aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants